Bug 202731 – Update libwebrtc third-party boringssl to M78

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Update libwebrtc third-party boringssl to M78

[youenn fablet]

Created attachment 380521 [details]
Patch

[youenn fablet]

GTK is probably missing updates to CMakeLists.txt.
At least Source/third_party/boringssl/src/crypto/evp/p_x25519_asn1.c
Maybe other files: curve_params.c, isogeny.c, fpx.c, sike.c, hrss.c, p_x25519.c, fp_generic.c

Alex, Phil, would you be able to help?
Otherwise, I can try to fiddle with CMakeLists.txt with the help of the EWS GTK/WPE bots, but the patch is large and slow to process.

[Philippe Normand]

I'll have a look!

[Philippe Normand]

Created attachment 380526 [details]
build fixes for GTK

[youenn fablet]

Created attachment 380530 [details]
Integrated GTK/WPE build changes

[youenn fablet]

(In reply to Philippe Normand from comment #4)
> Created attachment 380526 [details]
> build fixes for GTK

Thanks!

[WebKit Commit Bot]

Comment on attachment 380530 [details]
Integrated GTK/WPE build changes

Rejecting attachment 380530 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 380530, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
proj/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/include/gtest/internal/custom/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/include/gtest/internal/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/xcode/Samples/FrameworkSample/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/xcode/gtest.xcodeproj/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/xcode/Scripts/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/include/gtest/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/scripts/test/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/xcode/Samples/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/xcode/Config/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/xcode/Resources/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/m4/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/test/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/samples/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/src/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/cmake/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/codegear/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/make/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/docs/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/scripts/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/xcode/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/include/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/build-aux/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/android-cmake/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/infra/config/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/third_party/googletest/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/fipstools/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/infra/
	D+	Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/.github/

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:

    The following files contain tab characters:

        trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/asm/vpaes-armv8.pl
        trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/modes/asm/ghash-neon-armv8.pl
        trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/modes/asm/ghash-ssse3-x86.pl
        trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/modes/asm/ghash-ssse3-x86_64.pl
        trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/test/asm/trampoline-armv4.pl
        trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/test/asm/trampoline-armv8.pl
        trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/test/asm/trampoline-x86.pl
        trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/test/asm/trampoline-x86_64.pl

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
W: ababc87366a285dcc354e113f482b3f70e3c1da7 and refs/remotes/origin/master differ, using rebase:
:040000 040000 dd2b62c6945426f37b3399f4f8dcbbca166aa9ff 53869b764b257978204e22f74ea16c27e3fc4a4d M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   1f10227393c..d344d8f9a9c  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 250964 = 1f10227393c9dc21c9d2643241b56515c886ce78
r250965 = d344d8f9a9ce731fb4fcd9ac2e1d5d21f76e1e48
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13114300

[youenn fablet]

Created attachment 382726 [details]
Rebased

[youenn fablet]

Committed revision 251983.

[youenn fablet]

http://trac.webkit.org/changeset/251983/webkit

[Radar WebKit Bug Importer]

<rdar://problem/56861669>