Bug 202729 - Update libwebrtc third-party jsoncpp to M78
Summary: Update libwebrtc third-party jsoncpp to M78
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-09 01:32 PDT by youenn fablet
Modified: 2019-10-10 08:57 PDT (History)
13 users (show)

See Also:

Attachments
Patch (1.23 MB, patch)
2019-10-09 01:34 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (8.39 MB, patch)
2019-10-09 01:48 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Integrated GTK/WPE build changes (1.23 MB, patch)
2019-10-09 06:04 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (1.23 MB, patch)
2019-10-09 06:25 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-10-09 01:32:30 PDT 
Update libwebrtc third-party jsoncpp to M78
Comment 1 youenn fablet 2019-10-09 01:34:27 PDT 
Created attachment 380513 [details]
Patch
Comment 2 youenn fablet 2019-10-09 01:48:04 PDT 
Created attachment 380515 [details]
Patch
Comment 3 youenn fablet 2019-10-09 02:07:10 PDT 
GTK bot seems to have some issues with jsoncpp.
Any idea what might be the issue?
Comment 4 Philippe Normand 2019-10-09 02:09:45 PDT 
I'll have a look.
Comment 5 Philippe Normand 2019-10-09 02:23:02 PDT 
The libwebrtc CMakeLists.txt needs two changes:

line ~1423: add Source/third_party/jsoncpp/generated in target_include_directories so that version.h is found

line ~292: change the cpp files, should be:
    Source/third_party/jsoncpp/source/src/lib_json/json_reader.cpp
    Source/third_party/jsoncpp/source/src/lib_json/json_value.cpp
Comment 6 youenn fablet 2019-10-09 06:04:07 PDT 
Created attachment 380531 [details]
Integrated GTK/WPE build changes
Comment 7 youenn fablet 2019-10-09 06:04:58 PDT 
(In reply to Philippe Normand from comment #5)
> The libwebrtc CMakeLists.txt needs two changes:
> 
> line ~1423: add Source/third_party/jsoncpp/generated in
> target_include_directories so that version.h is found
> 
> line ~292: change the cpp files, should be:
>     Source/third_party/jsoncpp/source/src/lib_json/json_reader.cpp
>     Source/third_party/jsoncpp/source/src/lib_json/json_value.cpp

Thanks!
Comment 8 youenn fablet 2019-10-09 06:25:14 PDT 
Created attachment 380532 [details]
Patch
Comment 9 WebKit Commit Bot 2019-10-10 01:48:23 PDT 
Comment on attachment 380532 [details]
Patch

Rejecting attachment 380532 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 380532, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13113674
Comment 10 WebKit Commit Bot 2019-10-10 08:56:38 PDT 
Comment on attachment 380532 [details]
Patch

Clearing flags on attachment: 380532

Committed r250972: <https://trac.webkit.org/changeset/250972>
Comment 11 WebKit Commit Bot 2019-10-10 08:56:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-10-10 08:57:27 PDT 
<rdar://problem/56156481>