Bug 202721 - Remove unified plan runtime flag
Summary: Remove unified plan runtime flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 202700
Blocks:
  Show dependency tree / graph
 
Reported: 2019-10-09 00:26 PDT by youenn fablet
Modified: 2019-10-10 08:16 PDT (History)
22 users (show)

See Also:

Attachments
Patch (21.87 KB, patch)
2019-10-09 00:33 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (24.14 KB, patch)
2019-10-09 10:51 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews214 for win-future (14.04 MB, application/zip)
2019-10-10 01:48 PDT, EWS Watchlist 		no flags Details
Patch for landing (22.76 KB, patch)
2019-10-10 01:51 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-10-09 00:26:28 PDT 
Remove unified plan runtime flag
Comment 1 youenn fablet 2019-10-09 00:33:11 PDT 
Created attachment 380504 [details]
Patch
Comment 2 youenn fablet 2019-10-09 07:44:24 PDT 
I need to remove the ability to disable unified plan from glib
Comment 3 Philippe Normand 2019-10-09 07:48:10 PDT 
(In reply to youenn fablet from comment #2)
> I need to remove the ability to disable unified plan from glib

Remove the "offending" line then?
Comment 4 youenn fablet 2019-10-09 07:49:08 PDT 
(In reply to Philippe Normand from comment #3)
> (In reply to youenn fablet from comment #2)
> > I need to remove the ability to disable unified plan from glib
> 
> Remove the "offending" line then?

That is the plan.
Comment 5 Philippe Normand 2019-10-09 07:49:29 PDT 
I don't know if anyone uses the WEBKIT_WEBRTC_DISABLE_UNIFIED_PLAN env var, but now would be a good moment to remove it, in preparation for the 2.28 releases.
Comment 6 youenn fablet 2019-10-09 10:51:00 PDT 
Created attachment 380544 [details]
Patch
Comment 7 EWS Watchlist 2019-10-09 10:51:38 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 8 Geoffrey Garen 2019-10-09 10:59:44 PDT 
Comment on attachment 380544 [details]
Patch

r=me
Comment 9 EWS Watchlist 2019-10-10 01:48:41 PDT 
Comment on attachment 380544 [details]
Patch

Attachment 380544 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13113575

New failing tests:
http/tests/security/same-origin-appcache-blocked.html
Comment 10 EWS Watchlist 2019-10-10 01:48:43 PDT 
Created attachment 380611 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 11 youenn fablet 2019-10-10 01:51:13 PDT 
Created attachment 380612 [details]
Patch for landing
Comment 12 WebKit Commit Bot 2019-10-10 08:15:08 PDT 
Comment on attachment 380612 [details]
Patch for landing

Clearing flags on attachment: 380612

Committed r250969: <https://trac.webkit.org/changeset/250969>
Comment 13 WebKit Commit Bot 2019-10-10 08:15:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 14 Radar WebKit Bug Importer 2019-10-10 08:16:20 PDT 
<rdar://problem/56155447>