fast/history/page-cache-element-state-focused.html is failing on internal bots.
<rdar://problem/56082428>
Created attachment 380481 [details] WIP Patch Needs change log.
Created attachment 380490 [details] Patch
Comment on attachment 380490 [details] Patch Clearing flags on attachment: 380490 Committed r250912: <https://trac.webkit.org/changeset/250912>
All reviewed patches have been landed. Closing bug.
Comment on attachment 380490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380490&action=review > Source/WebCore/css/CSSDefaultStyleSheets.cpp:96 > +static const char* simpleUserAgentStyleSheet = "html,body,div{display:block}" CSS_DARK_MODE_ADDITION "head{display:none}body{margin:8px}div:focus,span:focus,a:focus{outline:auto " DEFAULT_OUTLINE_WIDTH " -webkit-focus-ring-color}a:any-link{color:-webkit-link;text-decoration:underline}a:any-link:active{color:-webkit-activelink}"; Tiny nitpick: There’s not enough const here. This declares a constant string, and a non-constant global variable that starts out pointing to it; but we don’t need to change the value of that global variable. We should add another const or constexpr so the pointer itself is constant too, not just the string contents. Or could use a constant array instead of a pointer to a string; I think that is a little smaller.
(In reply to Darin Adler from comment #6) > Comment on attachment 380490 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380490&action=review > > > Source/WebCore/css/CSSDefaultStyleSheets.cpp:96 > > +static const char* simpleUserAgentStyleSheet = "html,body,div{display:block}" CSS_DARK_MODE_ADDITION "head{display:none}body{margin:8px}div:focus,span:focus,a:focus{outline:auto " DEFAULT_OUTLINE_WIDTH " -webkit-focus-ring-color}a:any-link{color:-webkit-link;text-decoration:underline}a:any-link:active{color:-webkit-activelink}"; > > Tiny nitpick: There’s not enough const here. This declares a constant > string, and a non-constant global variable that starts out pointing to it; > but we don’t need to change the value of that global variable. We should add > another const or constexpr so the pointer itself is constant too, not just > the string contents. Or could use a constant array instead of a pointer to a > string; I think that is a little smaller. Landed a follow-up fix in <https://trac.webkit.org/changeset/250916> thanks. I opted for "static const char simpleUserAgentStyleSheet[]".