Bug 202703 - dataLogIf should be ALWAYS_INLINE
Summary: dataLogIf should be ALWAYS_INLINE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-08 13:19 PDT by Robin Morisset
Modified: 2019-10-08 15:17 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.73 KB, patch)
2019-10-08 13:21 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-10-08 13:19:11 PDT
We often have the following pattern:
```
static constexpr bool verbose = false;
...
dataLogLnIf(verbose, "Something is happening");
```
To make sure that these are always properly eliminated I'd like to make dataLogIf/dataLogLnIf ALWAYS_INLINE.

We may as well mark the branch as UNLIKELY too, for the cases where the condition comes from Options::verboseSomething.
Comment 1 Robin Morisset 2019-10-08 13:21:35 PDT
Created attachment 380457 [details]
Patch
Comment 2 WebKit Commit Bot 2019-10-08 15:16:11 PDT
Comment on attachment 380457 [details]
Patch

Clearing flags on attachment: 380457

Committed r250867: <https://trac.webkit.org/changeset/250867>
Comment 3 WebKit Commit Bot 2019-10-08 15:16:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-10-08 15:17:26 PDT
<rdar://problem/56094719>