Make AXIsolatedTree work compile again
<rdar://problem/56084968>
Created attachment 380587 [details] patch
Comment on attachment 380587 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=380587&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h:-48 > -class AXIsolatedTreeNode final : public AccessibilityObjectInterface, public ThreadSafeRefCounted<AXIsolatedTreeNode>, public CanMakeWeakPtr<AXIsolatedTreeNode> { If we use WeakPtr, there are assertions to ensure that when created on the main thread, it can only be accessed on the main thread. In this case we don't want to do that. We want to create these objects on the main thread and access on secondary
Created attachment 380591 [details] patch
Created attachment 380593 [details] patch
Created attachment 380654 [details] patch
Comment on attachment 380654 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=380654&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:-112 > - RELEASE_ASSERT(!isMainThread() || initialRequest); the first time we access objects we're still on the main thread, so we can't have this check unless we also have the initialRequest logic which seemed somewhat unnecessary > Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h:134 > + RefPtr<AXIsolatedTree> m_cachedTree; WeakPtrs require that objects made on main thread are only accessed on main thread, which is pretty much the opposite of what we're trying to do here > Source/WebKit/Configurations/BaseTarget.xcconfig:36 > +SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Versions/A/Frameworks; Need this for AccessibilitySPI.h
Comment on attachment 380654 [details] patch Clearing flags on attachment: 380654 Committed r251045: <https://trac.webkit.org/changeset/251045>
All reviewed patches have been landed. Closing bug.
Reverted r251045 for reason: Broke internal builds Committed r251074: <https://trac.webkit.org/changeset/251074>
Created attachment 380993 [details] Re-submitting r251045 with a fix for internal builds.
Comment on attachment 380993 [details] Re-submitting r251045 with a fix for internal builds. Clearing flags on attachment: 380993 Committed r251171: <https://trac.webkit.org/changeset/251171>