Bug 202697 – [LFC][Painting] Add very basic block and inline painting

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

only border/background color with simple text. no phases and z-index.

[Radar WebKit Bug Importer]

<rdar://problem/56076562>

[zalan]

Created attachment 380435 [details]
Patch

[zalan]

Created attachment 380437 [details]
Patch

[Antti Koivisto]

Comment on attachment 380437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380437&action=review

> Source/WebCore/layout/displaytree/DisplayPainter.cpp:99
> +static void paintInlineContent(GraphicsContext& context, const Box& absoluteDisplayBox, const RenderStyle& style, const String& content, const Layout::InlineFormattingState& formattingState)

Maybe things like GraphicsContext should become members of the Painter?

[zalan]

(In reply to Antti Koivisto from comment #4)
> Comment on attachment 380437 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380437&action=review
> 
> > Source/WebCore/layout/displaytree/DisplayPainter.cpp:99
> > +static void paintInlineContent(GraphicsContext& context, const Box& absoluteDisplayBox, const RenderStyle& style, const String& content, const Layout::InlineFormattingState& formattingState)
> 
> Maybe things like GraphicsContext should become members of the Painter?
Yeah, we need to figure out the proper setup here.

[WebKit Commit Bot]

Comment on attachment 380437 [details]
Patch

Clearing flags on attachment: 380437

Committed r250837: <https://trac.webkit.org/changeset/250837>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Sam Weinig]

Since historically, painting is hard to test, do you think there is anything we can do, as you start adding painting support, to make this more testable? 

For instance, and this is just a for instance, one idea would be to virtualize the GraphicsContext calls, and have a concrete implementation that just logs the calls. Then, for testing, we could do dump calls and test against an expected set of calls (a-la-a dump render tree).

[zalan]

(In reply to Sam Weinig from comment #8)
> Since historically, painting is hard to test, do you think there is anything
> we can do, as you start adding painting support, to make this more testable? 
> 
> For instance, and this is just a for instance, one idea would be to
> virtualize the GraphicsContext calls, and have a concrete implementation
> that just logs the calls. Then, for testing, we could do dump calls and test
> against an expected set of calls (a-la-a dump render tree).

This is a very good idea. We actually might be able to use the display list recording for this.