`HTMLCanvasElement.prototype.toDataURL` hasn't been hooked up for `GPUCanvasContext` yet, so calling `Canvas.requestContent` with a `WebGPUDevice` won't give us any good results. As such, the Web Inspector frontend should show something slightly more actionable, or at the very least something less obviously wrong.
Created attachment 380393 [details] Patch
Created attachment 380394 [details] [Image] After Patch is applied
Comment on attachment 380393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380393&action=review r=me > Source/WebInspectorUI/UserInterface/Models/Canvas.js:127 > + return true; I know this was written with future contextTypes in mind, but I'd just replace it with: return contextType !== Canvas.ContextType.WebGPU && contextType !== Canvas.ContextType.WebMetal;
Comment on attachment 380393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380393&action=review >> Source/WebInspectorUI/UserInterface/Models/Canvas.js:127 >> + return true; > > I know this was written with future contextTypes in mind, but I'd just replace it with: > > return contextType !== Canvas.ContextType.WebGPU && contextType !== Canvas.ContextType.WebMetal; I personally prefer this, as it's more future-proof.
Comment on attachment 380393 [details] Patch Clearing flags on attachment: 380393 Committed r250858: <https://trac.webkit.org/changeset/250858>
All reviewed patches have been landed. Closing bug.
<rdar://problem/56088775>