Bug 202652 - Bring up queues for Catalina
Summary: Bring up queues for Catalina
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Lewis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-07 13:38 PDT by Matt Lewis
Modified: 2019-10-10 11:36 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.01 KB, patch)
2019-10-07 13:50 PDT, Matt Lewis 		no flags Details | Formatted Diff | Diff
Patch (3.28 KB, patch)
2019-10-08 11:19 PDT, Matt Lewis 		jbedard: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2019-10-07 13:38:43 PDT 
Bring up queues for Catalina
Comment 1 Radar WebKit Bug Importer 2019-10-07 13:38:55 PDT 
<rdar://problem/56048776>
Comment 2 Matt Lewis 2019-10-07 13:50:24 PDT 
Created attachment 380356 [details]
Patch
Comment 3 Matt Lewis 2019-10-07 14:32:41 PDT 
Committed r250794: <https://trac.webkit.org/changeset/250794>
Comment 4 Matt Lewis 2019-10-08 11:15:17 PDT 
I forgot to add the triggerable config changes.
Comment 5 Matt Lewis 2019-10-08 11:19:24 PDT 
Created attachment 380445 [details]
Patch
Comment 6 Matt Lewis 2019-10-08 11:21:47 PDT 
Committed r250840: <https://trac.webkit.org/changeset/250840>
Comment 7 Aakash Jain 2019-10-10 11:07:05 PDT 
We also need to add mac-catalina to target_platform in https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py
Comment 8 Aakash Jain 2019-10-10 11:21:10 PDT 
Comment on attachment 380445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380445&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:439
> +                      "builderNames": ["Apple Mojave Debug WK2 (Tests)"]

This seems incorrect. It should be Catalina instead of Mojave.