Bug 202645 - [GTK] Navigation gesture improvements
Summary: [GTK] Navigation gesture improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-07 11:15 PDT by Alice Mikhaylenko
Modified: 2019-10-08 03:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.35 KB, patch)
2019-10-07 11:23 PDT, Alice Mikhaylenko 		cgarcia: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff
Patch (5.36 KB, patch)
2019-10-08 02:18 PDT, Alice Mikhaylenko 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alice Mikhaylenko 2019-10-07 11:15:53 PDT 
See the patch. (Yes, name's the same as in bug 194943)
Comment 1 Alice Mikhaylenko 2019-10-07 11:23:43 PDT 
Created attachment 380340 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-10-08 00:46:29 PDT 
Comment on attachment 380340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380340&action=review

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:184
> +        deltaX *= (double) Scrollbar::pixelsPerLineStep() / m_distance;

I know this is na existing issue, but please use C++ style cast.
Comment 3 Alice Mikhaylenko 2019-10-08 02:18:22 PDT 
Created attachment 380416 [details]
Patch

Sure, fixed
Comment 4 WebKit Commit Bot 2019-10-08 03:03:45 PDT 
Comment on attachment 380416 [details]
Patch

Clearing flags on attachment: 380416

Committed r250820: <https://trac.webkit.org/changeset/250820>
Comment 5 WebKit Commit Bot 2019-10-08 03:03:47 PDT 
All reviewed patches have been landed.  Closing bug.