Bug 202641 – Import autofocus Web Platform Tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ali Juma]

Import autofocus Web Platform Tests

[Ali Juma]

Created attachment 380337 [details]
WIP for EWS

[Ali Juma]

Created attachment 380343 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 380343 [details]
Patch

Clearing flags on attachment: 380343

Committed r250823: <https://trac.webkit.org/changeset/250823>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56072593>

[Truitt Savell]

The new test imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-attribute/update-the-rendering.html

added in https://trac.webkit.org/changeset/250823/webkit

is failing on Mojave wk2.

Diff:
--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-attribute/update-the-rendering-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-attribute/update-the-rendering-actual.txt
@@ -1,4 +1,4 @@
 
 
-FAIL "Flush autofocus candidates" should be happen after the first animation frame callbacks, and before a resize event in the next iteration of window event loop. assert_array_equals: lengths differ, expected 3 got 4
+FAIL "Flush autofocus candidates" should be happen after the first animation frame callbacks, and before a resize event in the next iteration of window event loop. assert_array_equals: property 0, expected "animationFrame" but got "autofocus"
 

does this need to be marked as failing?

[Truitt Savell]

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Finteraction%2Ffocus%2Fthe-autofocus-attribute%2Fupdate-the-rendering.html

[Ali Juma]

(In reply to Truitt Savell from comment #6)
> The new test
> imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-
> attribute/update-the-rendering.html
> 
> added in https://trac.webkit.org/changeset/250823/webkit
> 
> is failing on Mojave wk2.
> 
> Diff:
> ---
> /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/
> imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-
> attribute/update-the-rendering-expected.txt
> +++
> /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/
> imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-
> attribute/update-the-rendering-actual.txt
> @@ -1,4 +1,4 @@
>  
>  
> -FAIL "Flush autofocus candidates" should be happen after the first
> animation frame callbacks, and before a resize event in the next iteration
> of window event loop. assert_array_equals: lengths differ, expected 3 got 4
> +FAIL "Flush autofocus candidates" should be happen after the first
> animation frame callbacks, and before a resize event in the next iteration
> of window event loop. assert_array_equals: property 0, expected
> "animationFrame" but got "autofocus"
>  
> 
> does this need to be marked as failing?

Thanks, I'll update the expectations for Mojave WK2 and the other bots where this is failing.

[Ali Juma]

(In reply to Ali Juma from comment #8)
> (In reply to Truitt Savell from comment #6)
> > The new test
> > imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-
> > attribute/update-the-rendering.html
> > 
> > added in https://trac.webkit.org/changeset/250823/webkit
> > 
> > is failing on Mojave wk2.
> > 
> > Diff:
> > ---
> > /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/
> > imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-
> > attribute/update-the-rendering-expected.txt
> > +++
> > /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/
> > imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-
> > attribute/update-the-rendering-actual.txt
> > @@ -1,4 +1,4 @@
> >  
> >  
> > -FAIL "Flush autofocus candidates" should be happen after the first
> > animation frame callbacks, and before a resize event in the next iteration
> > of window event loop. assert_array_equals: lengths differ, expected 3 got 4
> > +FAIL "Flush autofocus candidates" should be happen after the first
> > animation frame callbacks, and before a resize event in the next iteration
> > of window event loop. assert_array_equals: property 0, expected
> > "animationFrame" but got "autofocus"
> >  
> > 
> > does this need to be marked as failing?
> 
> Thanks, I'll update the expectations for Mojave WK2 and the other bots where
> this is failing.

Turns out it's not just failing, it's also flaking. So I've updated TestExpectations in https://trac.webkit.org/changeset/250846/webkit.