Bug 202628 – WebPageProxy::updatePlayingMediaDidChange should protect from a null m_userMediaPermissionRequestManager

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

WebPageProxy::updatePlayingMediaDidChange should protect from a null m_userMediaPermissionRequestManager

[youenn fablet]

<rdar://problem/55935091>

[youenn fablet]

Created attachment 380312 [details]
Patch

[Eric Carlson]

Comment on attachment 380312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380312&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:8309
> +        ASSERT(m_userMediaPermissionRequestManager);

If we expect m_userMediaPermissionRequestManager to be NULL some of the time, do we really want an ASSERT here?

[youenn fablet]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 380312 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380312&action=review
> 
> > Source/WebKit/UIProcess/WebPageProxy.cpp:8309
> > +        ASSERT(m_userMediaPermissionRequestManager);
> 
> If we expect m_userMediaPermissionRequestManager to be NULL some of the
> time, do we really want an ASSERT here?

By design, when nulling m_userMediaPermissionRequestManager, we set back the capture state to none. For the capture state to be different from None, m_userMediaPermissionRequestManager should in theory be recreated.

So we do not expect it to be null but we cannot ignore the fact that a wrong IPC message may happen.

[WebKit Commit Bot]

Comment on attachment 380312 [details]
Patch

Clearing flags on attachment: 380312

Committed r250773: <https://trac.webkit.org/changeset/250773>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.