Bug 202620 - [CSS Shadow Parts] Internal shadow pseudo elements should work with ::part
Summary: [CSS Shadow Parts] Internal shadow pseudo elements should work with ::part
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 149443
  Show dependency treegraph
 
Reported: 2019-10-06 03:09 PDT by Antti Koivisto
Modified: 2019-10-08 00:32 PDT (History)
10 users (show)

See Also:


Attachments
patch (11.06 KB, patch)
2019-10-06 06:08 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (11.15 KB, patch)
2019-10-06 06:39 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (11.52 KB, patch)
2019-10-07 06:58 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-10-06 03:09:24 PDT
::part(foo)::placeholder
Comment 1 Antti Koivisto 2019-10-06 06:08:44 PDT
Created attachment 380295 [details]
patch
Comment 2 Antti Koivisto 2019-10-06 06:39:23 PDT
Created attachment 380297 [details]
patch
Comment 3 Antti Koivisto 2019-10-07 06:58:15 PDT
Created attachment 380323 [details]
patch
Comment 4 Ryosuke Niwa 2019-10-07 13:50:05 PDT
Comment on attachment 380323 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380323&action=review

> LayoutTests/ChangeLog:11
> +        * TestExpectations:

Can we add tests for ::before & ::after?
Comment 5 Antti Koivisto 2019-10-07 23:48:18 PDT
> Can we add tests for ::before & ::after?

They are already tested by a WPT test (and unaffected by this patch). I'll land some more tests separately.
Comment 6 Ryosuke Niwa 2019-10-07 23:50:27 PDT
(In reply to Antti Koivisto from comment #5)
> > Can we add tests for ::before & ::after?
> 
> They are already tested by a WPT test (and unaffected by this patch). I'll
> land some more tests separately.

Nice!
Comment 7 WebKit Commit Bot 2019-10-08 00:31:44 PDT
Comment on attachment 380323 [details]
patch

Clearing flags on attachment: 380323

Committed r250817: <https://trac.webkit.org/changeset/250817>
Comment 8 WebKit Commit Bot 2019-10-08 00:31:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-10-08 00:32:16 PDT
<rdar://problem/56065249>