Bug 202610 - [LFC] Remove redundant includes.
Summary: [LFC] Remove redundant includes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-04 21:16 PDT by zalan
Modified: 2019-10-05 07:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (21.39 KB, patch)
2019-10-04 21:19 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (21.94 KB, patch)
2019-10-05 06:20 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-10-04 21:16:10 PDT 
don't want them
Comment 1 Radar WebKit Bug Importer 2019-10-04 21:16:54 PDT 
<rdar://problem/56003250>
Comment 2 zalan 2019-10-04 21:19:44 PDT 
Created attachment 380276 [details]
Patch
Comment 3 Tim Horton 2019-10-04 21:55:54 PDT 
Comment on attachment 380276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380276&action=review

You know I’m on board :P

> Source/WebCore/layout/FormattingContext.h:52
> +struct HeightAndMargin;

I usually sort the different kinds separately, but I don’t think it’s a rule :)
Comment 4 zalan 2019-10-05 06:20:33 PDT 
Created attachment 380282 [details]
Patch
Comment 5 zalan 2019-10-05 06:23:12 PDT 
(In reply to Tim Horton from comment #3)
> Comment on attachment 380276 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380276&action=review
> 
> You know I’m on board :P
> 
> > Source/WebCore/layout/FormattingContext.h:52
> > +struct HeightAndMargin;
> 
> I usually sort the different kinds separately, but I don’t think it’s a rule
> :)
Me too! I just assumed there was this alphabetical sorting rule (which apparently not the case)
Comment 6 WebKit Commit Bot 2019-10-05 07:05:55 PDT 
Comment on attachment 380282 [details]
Patch

Clearing flags on attachment: 380282

Committed r250766: <https://trac.webkit.org/changeset/250766>
Comment 7 WebKit Commit Bot 2019-10-05 07:05:57 PDT 
All reviewed patches have been landed.  Closing bug.