Bug 202606 – [perf dashboard] Test fressness popover sometimes point to wrong place

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[Zhifei Fang]

[perf dashboard] Test fressness popover sometimes point to wrong place

[Zhifei Fang]

Created attachment 380257 [details]
Patch

[Zhifei Fang]

This patch need this: https://bugs.webkit.org/show_bug.cgi?id=202602

[Ryosuke Niwa]

Comment on attachment 380257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380257&action=review

> Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:350
> +            #tooltip-container {
> +                position: relative;
> +            }

Do we really need this position: relative?
#tooltip-anchor being position: absolute should be sufficient, no?

[Zhifei Fang]

Created attachment 380272 [details]
Patch

[Zhifei Fang]

(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 380257 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380257&action=review
> 
> > Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:350
> > +            #tooltip-container {
> > +                position: relative;
> > +            }
> 
> Do we really need this position: relative?
> #tooltip-anchor being position: absolute should be sufficient, no?

Right, https://developer.mozilla.org/en-US/docs/Web/CSS/Containing_block

I think we don't need this.

[WebKit Commit Bot]

Comment on attachment 380272 [details]
Patch

Clearing flags on attachment: 380272

Committed r250760: <https://trac.webkit.org/changeset/250760>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56001218>