Bug 202606 - [perf dashboard] Test fressness popover sometimes point to wrong place
Summary: [perf dashboard] Test fressness popover sometimes point to wrong place
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zhifei Fang
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-04 15:01 PDT by Zhifei Fang
Modified: 2019-10-04 18:18 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.03 KB, patch)
2019-10-04 15:04 PDT, Zhifei Fang 		no flags Details | Formatted Diff | Diff
Patch (4.87 KB, patch)
2019-10-04 17:28 PDT, Zhifei Fang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhifei Fang 2019-10-04 15:01:25 PDT 
[perf dashboard] Test fressness popover sometimes point to wrong place
Comment 1 Zhifei Fang 2019-10-04 15:04:24 PDT 
Created attachment 380257 [details]
Patch
Comment 2 Zhifei Fang 2019-10-04 15:05:39 PDT 
This patch need this: https://bugs.webkit.org/show_bug.cgi?id=202602
Comment 3 Ryosuke Niwa 2019-10-04 17:16:04 PDT 
Comment on attachment 380257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380257&action=review

> Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:350
> +            #tooltip-container {
> +                position: relative;
> +            }

Do we really need this position: relative?
#tooltip-anchor being position: absolute should be sufficient, no?
Comment 4 Zhifei Fang 2019-10-04 17:28:41 PDT 
Created attachment 380272 [details]
Patch
Comment 5 Zhifei Fang 2019-10-04 17:29:13 PDT 
(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 380257 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380257&action=review
> 
> > Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:350
> > +            #tooltip-container {
> > +                position: relative;
> > +            }
> 
> Do we really need this position: relative?
> #tooltip-anchor being position: absolute should be sufficient, no?

Right, https://developer.mozilla.org/en-US/docs/Web/CSS/Containing_block

I think we don't need this.
Comment 6 WebKit Commit Bot 2019-10-04 18:17:05 PDT 
Comment on attachment 380272 [details]
Patch

Clearing flags on attachment: 380272

Committed r250760: <https://trac.webkit.org/changeset/250760>
Comment 7 WebKit Commit Bot 2019-10-04 18:17:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-10-04 18:18:16 PDT 
<rdar://problem/56001218>