Bug 202593 - Allow using WebGL 2 when USE_ANGLE=1
Summary: Allow using WebGL 2 when USE_ANGLE=1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
Depends on:
Blocks: webglangle
  Show dependency treegraph
 
Reported: 2019-10-04 12:23 PDT by James Darpinian
Modified: 2020-03-11 17:12 PDT (History)
11 users (show)

See Also:


Attachments
Allow using WebGL 2 when USE_ANGLE=1 (3.30 KB, patch)
2019-10-04 12:26 PDT, James Darpinian
no flags Details | Formatted Diff | Diff
Fix USE macro (3.31 KB, patch)
2019-10-04 12:34 PDT, James Darpinian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2019-10-04 12:23:05 PDT
Allow using WebGL 2 when USE_ANGLE=1
Comment 1 James Darpinian 2019-10-04 12:26:02 PDT
Created attachment 380232 [details]
Allow using WebGL 2 when USE_ANGLE=1
Comment 2 Dean Jackson 2019-10-04 12:30:52 PDT
Comment on attachment 380232 [details]
Allow using WebGL 2 when USE_ANGLE=1

View in context: https://bugs.webkit.org/attachment.cgi?id=380232&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:614
> +#if ENABLE(WEBGL2) && PLATFORM(MAC) && !USE_ANGLE

!USE(ANGLE)
Comment 3 James Darpinian 2019-10-04 12:34:24 PDT
Created attachment 380234 [details]
Fix USE macro
Comment 4 WebKit Commit Bot 2019-10-04 12:57:26 PDT
Comment on attachment 380234 [details]
Fix USE macro

Clearing flags on attachment: 380234

Committed r250740: <https://trac.webkit.org/changeset/250740>
Comment 5 WebKit Commit Bot 2019-10-04 12:57:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-10-04 12:58:15 PDT
<rdar://problem/55992173>