Bug 202590 – DOMCache should not prevent pages from entering the back/forward cache

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Chris Dumez]

DOMCache should not prevent pages from entering the back/forward cache.

[Chris Dumez]

Created attachment 380233 [details]
Patch

[Chris Dumez]

Created attachment 380235 [details]
Patch

[Geoffrey Garen]

Comment on attachment 380235 [details]
Patch

EWS seems to be crashing in DOMCache tests.

[Chris Dumez]

Created attachment 380251 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/56036489>

[Chris Dumez]

Comment on attachment 380251 [details]
Patch

Will investigate WK1 failures.

[Chris Dumez]

(In reply to Chris Dumez from comment #6)
> Comment on attachment 380251 [details]
> Patch
> 
> Will investigate WK1 failures.

Oh, it looks like DOMCache is WK2 only. Will skip the new test on WK1.

[Chris Dumez]

Created attachment 380329 [details]
Patch

[youenn fablet]

Comment on attachment 380329 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380329&action=review

> Source/WebCore/Modules/cache/DOMCache.cpp:450
> +    queryCache(request.releaseNonNull(), WTFMove(options), [this, protectedThis = makeRef(*this), promise = WTFMove(promise)](ExceptionOr<Vector<CacheStorageRecord>>&& result) mutable {

auto&& here and above as well if we want.

> Source/WebCore/Modules/cache/DOMCache.h:61
> +    using MatchCallback = WTF::Function<void(ExceptionOr<RefPtr<FetchResponse>>)>;

s/WTF:://

> Source/WebCore/Modules/cache/DOMCacheStorage.cpp:63
> +    cache.doMatch(WTFMove(info), WTFMove(options), [caches = WTFMove(caches), info, options, completionHandler = WTFMove(completionHandler), index](ExceptionOr<RefPtr<FetchResponse>>&& result) mutable {

auto&&

> Source/WebCore/Modules/cache/DOMCacheStorage.cpp:88
> +    startSequentialMatch(WTF::map(m_caches, copyCache), WTFMove(info), WTFMove(options), [this, pendingActivity = makePendingActivity(*this), promise = WTFMove(promise)](ExceptionOr<RefPtr<FetchResponse>>&& result) mutable {

auto&&

[Chris Dumez]

Created attachment 380348 [details]
Patch

[Chris Dumez]

Comment on attachment 380348 [details]
Patch

Clearing flags on attachment: 380348

Committed r250786: <https://trac.webkit.org/changeset/250786>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Aakash Jain]

> Committed r250786: <https://trac.webkit.org/changeset/250786>
This commit seems to have broken API Test: WebKit.DefaultQuota (Bug 202850). EWS also indicated that failure.

[Chris Dumez]

(In reply to Aakash Jain from comment #13)
> > Committed r250786: <https://trac.webkit.org/changeset/250786>
> This commit seems to have broken API Test: WebKit.DefaultQuota (Bug 202850).
> EWS also indicated that failure.

Odd, I am investigating.