Bug 202585 - PendingImageBitmap should not prevent entering the back/forward cache
Summary: PendingImageBitmap should not prevent entering the back/forward cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 202293
  Show dependency treegraph
 
Reported: 2019-10-04 08:43 PDT by Chris Dumez
Modified: 2019-10-07 14:09 PDT (History)
11 users (show)

See Also:


Attachments
Patch (9.00 KB, patch)
2019-10-04 10:43 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-04 08:43:46 PDT
PendingImageBitmap should not prevent entering the back/forward cache.
Comment 1 Chris Dumez 2019-10-04 10:43:15 PDT
Created attachment 380227 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-10-07 08:13:56 PDT
<rdar://problem/56036482>
Comment 3 Tim Horton 2019-10-07 10:58:15 PDT
Comment on attachment 380227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380227&action=review

> LayoutTests/TestExpectations:265
> +fast/history/page-cache-createImageBitmap.html [ DumpJSConsoleLogInStdErr ]

Weird, why is this an option here instead of in the <!-- webkit-test-runner --> block I wonder
Comment 4 WebKit Commit Bot 2019-10-07 11:58:30 PDT
Comment on attachment 380227 [details]
Patch

Clearing flags on attachment: 380227

Committed r250782: <https://trac.webkit.org/changeset/250782>
Comment 5 WebKit Commit Bot 2019-10-07 11:58:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Chris Dumez 2019-10-07 13:03:32 PDT
(In reply to Tim Horton from comment #3)
> Comment on attachment 380227 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380227&action=review
> 
> > LayoutTests/TestExpectations:265
> > +fast/history/page-cache-createImageBitmap.html [ DumpJSConsoleLogInStdErr ]
> 
> Weird, why is this an option here instead of in the <!-- webkit-test-runner
> --> block I wonder

Do we have such a <!-- webkit-test-runner option?
Comment 7 Tim Horton 2019-10-07 14:08:35 PDT
(In reply to Chris Dumez from comment #6)
> (In reply to Tim Horton from comment #3)
> > Comment on attachment 380227 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=380227&action=review
> > 
> > > LayoutTests/TestExpectations:265
> > > +fast/history/page-cache-createImageBitmap.html [ DumpJSConsoleLogInStdErr ]
> > 
> > Weird, why is this an option here instead of in the <!-- webkit-test-runner
> > --> block I wonder
> 
> Do we have such a <!-- webkit-test-runner option?

I don't know! This wasn't so much a complaint about your patch as a "huh it's weird we do this that way".
Comment 8 Chris Dumez 2019-10-07 14:09:57 PDT
(In reply to Tim Horton from comment #7)
> (In reply to Chris Dumez from comment #6)
> > (In reply to Tim Horton from comment #3)
> > > Comment on attachment 380227 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=380227&action=review
> > > 
> > > > LayoutTests/TestExpectations:265
> > > > +fast/history/page-cache-createImageBitmap.html [ DumpJSConsoleLogInStdErr ]
> > > 
> > > Weird, why is this an option here instead of in the <!-- webkit-test-runner
> > > --> block I wonder
> > 
> > Do we have such a <!-- webkit-test-runner option?
> 
> I don't know! This wasn't so much a complaint about your patch as a "huh
> it's weird we do this that way".

Historically, we've had to use this a lot of Web-platform-tests, which we cannot modify. I think this feature was actually added for WPT.