Bug 202575 - [GTK][WPE] REGRESSION(r250673): connection to network process is broken after r250673
Summary: [GTK][WPE] REGRESSION(r250673): connection to network process is broken after...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2019-10-04 01:48 PDT by Carlos Garcia Campos
Modified: 2019-10-04 02:43 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.81 KB, patch)
2019-10-04 01:52 PDT, Carlos Garcia Campos
clopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-10-04 01:48:24 PDT
The file descriptor is now closed when the IPC::Attachment is destroyed in NetworkProcessConnectionInfo destructor. In case of unix domain sockets we need to transfer the ownership of the fd to NetworkProcessConnection, but NetworkProcessConnectionInfo is ow keeping the ownership.
Comment 1 Carlos Garcia Campos 2019-10-04 01:52:59 PDT
Created attachment 380198 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-10-04 02:43:03 PDT
Committed r250713: <https://trac.webkit.org/changeset/250713>