Spec: https://html.spec.whatwg.org/multipage/canvas.html#dom-offscreencanvas-transfertoimagebitmap
Created attachment 380627 [details] Patch
Created attachment 384704 [details] Patch
Comment on attachment 384704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384704&action=review > Source/WebCore/html/OffscreenCanvas.cpp:195 > + m_hasCreatedImageBuffer = true; Shouldn't this be set only after the nullptr return path? > Source/WebCore/html/OffscreenCanvas.cpp:197 > + if (!width() || !height()) size().isEmpty()?
Created attachment 384801 [details] Patch
Comment on attachment 384801 [details] Patch Clearing flags on attachment: 384801 Committed r253099: <https://trac.webkit.org/changeset/253099>
All reviewed patches have been landed. Closing bug.
<rdar://problem/57620574>
Comment on attachment 384801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384801&action=review > Source/WebCore/html/CanvasBase.h:113 > + std::unique_ptr<ImageBuffer> setImageBuffer(std::unique_ptr<ImageBuffer>&&) const; C++ calls this operation "exchange" as in "std::exchange", rather than "set". I think we might want to name this function accordingly.