Bug 202565 - [WebAuthn] Write more tests for _WKWebAuthenticationPanel
Summary: [WebAuthn] Write more tests for _WKWebAuthenticationPanel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on: 202560
Blocks: 182769
  Show dependency tree / graph
 
Reported: 2019-10-03 22:52 PDT by Jiewen Tan
Modified: 2019-10-15 11:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (20.07 KB, patch)
2019-10-10 14:38 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Patch (20.12 KB, patch)
2019-10-11 01:33 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2019-10-03 22:52:55 PDT 
Write more tests for _WKWebAuthenticationPanel. Potential test set could be:
1) a test without any panel client;
2) a test with _WKWebAuthenticationResultSucceeded;
3) a test with race condition that a new request comes in between;
4) a test with a new request cancels the other.
Comment 1 Radar WebKit Bug Importer 2019-10-03 22:53:28 PDT 
<rdar://problem/55974128>
Comment 2 Jiewen Tan 2019-10-10 14:38:00 PDT 
Created attachment 380686 [details]
Patch
Comment 3 Jiewen Tan 2019-10-11 01:33:25 PDT 
Created attachment 380733 [details]
Patch
Comment 4 Jiewen Tan 2019-10-11 12:05:39 PDT 
I don't think the iOS-WK2 failures should blame this patch.
Comment 5 Brent Fulgham 2019-10-15 09:10:26 PDT 
(In reply to Jiewen Tan from comment #4)
> I don't think the iOS-WK2 failures should blame this patch.

Yes. It looks like both of the test failures are flaky crashes, according to the dashboard.
Comment 6 Brent Fulgham 2019-10-15 09:12:47 PDT 
Comment on attachment 380733 [details]
Patch

It's always good to see more tests! r=me (please watch the bots once this lands to make sure we don't introduce any bot issues).
Comment 7 Jiewen Tan 2019-10-15 10:38:24 PDT 
Comment on attachment 380733 [details]
Patch

Thanks Brent for r+ this patch.
Comment 8 WebKit Commit Bot 2019-10-15 11:21:59 PDT 
Comment on attachment 380733 [details]
Patch

Clearing flags on attachment: 380733

Committed r251148: <https://trac.webkit.org/changeset/251148>
Comment 9 WebKit Commit Bot 2019-10-15 11:22:01 PDT 
All reviewed patches have been landed.  Closing bug.