Bug 202563 - [WebAuthn] Supply FrameInfo in -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]
Summary: [WebAuthn] Supply FrameInfo in -[WKUIDelegatePrivate _webView:runWebAuthentic...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on: 202559
Blocks: 181943
  Show dependency tree / graph
 
Reported: 2019-10-03 22:42 PDT by Jiewen Tan
Modified: 2019-10-23 12:36 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.15 KB, patch)
2019-10-22 03:14 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Patch (29.99 KB, patch)
2019-10-22 16:30 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Patch (30.17 KB, patch)
2019-10-22 23:08 PDT, Jiewen Tan 		bfulgham: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2019-10-03 22:42:24 PDT 
Supply FrameInfo in -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:].
Comment 1 Radar WebKit Bug Importer 2019-10-03 22:42:48 PDT 
<rdar://problem/55973968>
Comment 2 Jiewen Tan 2019-10-22 03:14:33 PDT 
Created attachment 381534 [details]
Patch
Comment 3 Jiewen Tan 2019-10-22 16:30:10 PDT 
Created attachment 381625 [details]
Patch
Comment 4 Jiewen Tan 2019-10-22 22:49:27 PDT 
This patch here conflicts with Bug 202561 on some minor ways. Will rebase it depending on which one get landed first.
Comment 5 Jiewen Tan 2019-10-22 23:08:20 PDT 
Created attachment 381659 [details]
Patch
Comment 6 Brent Fulgham 2019-10-23 08:44:21 PDT 
Comment on attachment 381659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381659&action=review

I have some minor suggestions, but overall looks good! r=me

> Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:74
> +        }, [&](const  ExceptionData& exception) {

It looks like you have two spaces between 'const' and 'ExceptionData&'.

> Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:47
> +void WebAuthenticatorCoordinator::makeCredential(const Frame& frame, const SecurityOrigin& origin, const Vector<uint8_t>& hash, const PublicKeyCredentialCreationOptions& options, RequestCompletionHandler&& handler)

Since origin and hash are coming from the message passing, I wonder if they could be WTFMove'd? Surely the hash would be worth moving.
Comment 7 Jiewen Tan 2019-10-23 12:33:00 PDT 
Comment on attachment 381659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381659&action=review

Thanks Brent for r+ this patch.

>> Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:74
>> +        }, [&](const  ExceptionData& exception) {
> 
> It looks like you have two spaces between 'const' and 'ExceptionData&'.

Fixed.

>> Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:47
>> +void WebAuthenticatorCoordinator::makeCredential(const Frame& frame, const SecurityOrigin& origin, const Vector<uint8_t>& hash, const PublicKeyCredentialCreationOptions& options, RequestCompletionHandler&& handler)
> 
> Since origin and hash are coming from the message passing, I wonder if they could be WTFMove'd? Surely the hash would be worth moving.

This is actually for sending the message, and therefore && will do nothing here.
Comment 8 Jiewen Tan 2019-10-23 12:36:50 PDT 
Committed r251489: <https://trac.webkit.org/changeset/251489>