Bug 202562 - Node::ref/deref should be const
Summary: Node::ref/deref should be const
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-03 22:39 PDT by Antti Koivisto
Modified: 2019-10-06 02:58 PDT (History)
13 users (show)

See Also:

Attachments
patch (16.93 KB, patch)
2019-10-04 02:22 PDT, Antti Koivisto 		rniwa: review+
Details | Formatted Diff | Diff
patch (16.92 KB, patch)
2019-10-06 02:14 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-10-03 22:39:56 PDT 
So you can have RefPtr<const Element>. This matches RefCounted.
Comment 1 Ryosuke Niwa 2019-10-03 22:41:38 PDT 
Makes sense.
Comment 2 Antti Koivisto 2019-10-04 02:22:14 PDT 
Created attachment 380203 [details]
patch
Comment 3 Ryosuke Niwa 2019-10-04 11:57:38 PDT 
Comment on attachment 380203 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380203&action=review

> Source/WebCore/css/ElementRuleCollector.h:105
> +    RefPtr<const Element> m_shadowHostInPartRuleScope { nullptr };

No need for { ~ }.
Comment 4 Antti Koivisto 2019-10-06 02:14:00 PDT 
Created attachment 380293 [details]
patch
Comment 5 WebKit Commit Bot 2019-10-06 02:57:48 PDT 
Comment on attachment 380293 [details]
patch

Clearing flags on attachment: 380293

Committed r250768: <https://trac.webkit.org/changeset/250768>
Comment 6 WebKit Commit Bot 2019-10-06 02:57:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-10-06 02:58:14 PDT 
<rdar://problem/56015817>