Bug 202553 - Move WKProcessPool._registerURLSchemeServiceWorkersCanHandle to _WKWebsiteDataStoreConfiguration
Summary: Move WKProcessPool._registerURLSchemeServiceWorkersCanHandle to _WKWebsiteDat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-03 17:50 PDT by Alex Christensen
Modified: 2019-10-11 09:18 PDT (History)
3 users (show)

See Also:

Attachments
Patch (69.33 KB, patch)
2019-10-03 17:52 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (69.25 KB, patch)
2019-10-03 18:03 PDT, Alex Christensen 		youennf: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-10-03 17:50:13 PDT 
Move WKProcessPool._registerURLSchemeServiceWorkersCanHandle to _WKWebsiteDataStoreConfiguration
Comment 1 Alex Christensen 2019-10-03 17:52:24 PDT 
Created attachment 380171 [details]
Patch
Comment 2 Alex Christensen 2019-10-03 18:03:57 PDT 
Created attachment 380175 [details]
Patch
Comment 3 youenn fablet 2019-10-04 07:54:25 PDT 
Comment on attachment 380175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380175&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2429
> +void NetworkProcess::addServiceWorkerSession(PAL::SessionID sessionID, bool processTerminationDelayEnabled, HashSet<String>&& registeredSchemes, String& serviceWorkerRegistrationDirectory, const SandboxExtension::Handle& handle)

Seems strange to have a String& serviceWorkerRegistrationDirectory.
I guess this would be a String&& ideally.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:489
> +    [dataStore removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() {

It might be good to leave a test using the default data store.
Comment 4 Alex Christensen 2019-10-04 09:43:36 PDT 
Done, and done!

http://trac.webkit.org/r250728
Comment 5 Radar WebKit Bug Importer 2019-10-04 09:44:19 PDT 
<rdar://problem/55985536>