Bug 202552 - ASSERTION FAILED: m_transactionOperationsInProgressQueue.first() == &operation in IDBTransaction::operationCompletedOnClient
Summary: ASSERTION FAILED: m_transactionOperationsInProgressQueue.first() == &operatio...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
Keywords: InRadar
Depends on:
Reported: 2019-10-03 17:46 PDT by Sihui Liu
Modified: 2019-10-07 15:37 PDT (History)
8 users (show)

See Also:

Patch (34.04 KB, patch)
2019-10-03 17:55 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch (35.41 KB, patch)
2019-10-03 23:26 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch (35.89 KB, patch)
2019-10-04 10:43 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch for landing (35.95 KB, patch)
2019-10-07 14:58 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-10-03 17:46:05 PDT
If there is quota error for some request, we send back an error response immediately without dispatching a task to database thread and waiting for result from database thread. However, web process expects to receive results for request in the order of requests being sent.
One simple solution is to dispatch a task with the quota error to the background thread, to make sure requests are handled in order on the background thread.
Comment 1 Sihui Liu 2019-10-03 17:55:34 PDT
Created attachment 380172 [details]
Comment 2 Alex Christensen 2019-10-03 20:09:41 PDT
Code change looks good.  Test needs some polish.
Comment 3 Sihui Liu 2019-10-03 23:26:06 PDT
Created attachment 380189 [details]
Comment 4 Sihui Liu 2019-10-04 10:43:11 PDT
Created attachment 380226 [details]
Comment 5 Sihui Liu 2019-10-07 14:58:32 PDT
Created attachment 380365 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-10-07 15:36:54 PDT
Comment on attachment 380365 [details]
Patch for landing

Clearing flags on attachment: 380365

Committed r250800: <https://trac.webkit.org/changeset/250800>
Comment 7 WebKit Commit Bot 2019-10-07 15:36:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-10-07 15:37:16 PDT