Bug 20255 - Coding style fixes to EventHandler
Summary: Coding style fixes to EventHandler
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-01 08:39 PDT by Joe Mason
Modified: 2023-11-22 10:55 PST (History)
4 users (show)

See Also:

Attachments
Patch to fix these problems (1.18 KB, patch)
2008-08-01 08:40 PDT, Joe Mason 		no flags Details | Formatted Diff | Diff
Same patch with ChangeLog (1.79 KB, patch)
2008-08-04 15:24 PDT, Joe Mason 		eric: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Mason 2008-08-01 08:39:30 PDT 
Just a few misc problems I noticed when looking at EventHandler:

All of the fields are public, even though some of them have accessors!  That's just bad practice.

The comment about m_capturingMouseEventsNode in handleMousePressEvent is pretty unclear.  It took me a while to figure out what it meant.
Comment 1 Joe Mason 2008-08-01 08:40:45 PDT 
Created attachment 22600 [details]
Patch to fix these problems

Attached patch adds a "private:" keyword in EventHandler.h and rewrites the comment slightly.
Comment 2 Joe Mason 2008-08-04 15:24:39 PDT 
Created attachment 22642 [details]
Same patch with ChangeLog

Added ChangeLog to the patch.
Comment 3 Joe Mason 2008-08-04 15:41:51 PDT 
Comment on attachment 22642 [details]
Same patch with ChangeLog

RequestEE != RequestER
Comment 4 Eric Seidel (no email) 2008-08-04 20:43:31 PDT 
Comment on attachment 22642 [details]
Same patch with ChangeLog

They're already private. :)
Comment 5 Ahmad Saleem 2023-11-22 10:55:19 PST 
@Abrar & @Wenson - Do we need this old bug anymore or we can close this?