UNCONFIRMED20255
Coding style fixes to EventHandler 
https://bugs.webkit.org/show_bug.cgi?id=20255
Summary Coding style fixes to EventHandler
Joe Mason
Reported 2008-08-01 08:39:30 PDT
Just a few misc problems I noticed when looking at EventHandler: All of the fields are public, even though some of them have accessors! That's just bad practice. The comment about m_capturingMouseEventsNode in handleMousePressEvent is pretty unclear. It took me a while to figure out what it meant.
Attachments
Patch to fix these problems (1.18 KB, patch)
2008-08-01 08:40 PDT, Joe Mason 		no flags
DetailsFormatted DiffDiff
Same patch with ChangeLog (1.79 KB, patch)
2008-08-04 15:24 PDT, Joe Mason 		eric: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joe Mason
Comment 1 2008-08-01 08:40:45 PDT
Created attachment 22600 [details] Patch to fix these problems Attached patch adds a "private:" keyword in EventHandler.h and rewrites the comment slightly.
Joe Mason
Comment 2 2008-08-04 15:24:39 PDT
Created attachment 22642 [details] Same patch with ChangeLog Added ChangeLog to the patch.
Joe Mason
Comment 3 2008-08-04 15:41:51 PDT
Comment on attachment 22642 [details] Same patch with ChangeLog RequestEE != RequestER
Eric Seidel (no email)
Comment 4 2008-08-04 20:43:31 PDT
Comment on attachment 22642 [details] Same patch with ChangeLog They're already private. :)
Ahmad Saleem
Comment 5 2023-11-22 10:55:19 PST
@Abrar & @Wenson - Do we need this old bug anymore or we can close this?
Note You need to log in before you can comment on or make changes to this bug.