Bug 202546 - [WinCairo] Remote Inspector doesn't gracefully shutdown
Summary: [WinCairo] Remote Inspector doesn't gracefully shutdown
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-03 15:18 PDT by Christopher Reid
Modified: 2019-10-03 22:06 PDT (History)
13 users (show)

See Also:

Attachments
patch (3.28 KB, patch)
2019-10-03 15:33 PDT, Christopher Reid 		no flags Details | Formatted Diff | Diff
Rebased patch (3.34 KB, patch)
2019-10-03 15:41 PDT, Christopher Reid 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Reid 2019-10-03 15:18:03 PDT 
Windows sockets need to call shutdown before closesocket.
https://docs.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-closesocket

This causes some issues when the client closed then immediately initiated a new connection.
The close isn't being seen by the server until much later causing the accept call to fail.
Comment 1 Christopher Reid 2019-10-03 15:33:32 PDT 
Created attachment 380165 [details]
patch
Comment 2 Christopher Reid 2019-10-03 15:41:39 PDT 
Created attachment 380166 [details]
Rebased patch
Comment 3 WebKit Commit Bot 2019-10-03 22:05:07 PDT 
Comment on attachment 380166 [details]
Rebased patch

Clearing flags on attachment: 380166

Committed r250699: <https://trac.webkit.org/changeset/250699>
Comment 4 WebKit Commit Bot 2019-10-03 22:05:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-10-03 22:06:15 PDT 
<rdar://problem/55973313>