Bug 202545 – Fix WebGL 1 conformance regressions when USE_ANGLE=1

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[James Darpinian]

Fix WebGL 1 conformance regressions when USE_ANGLE=1

[James Darpinian]

Created attachment 380163 [details]
Fix WebGL 1 conformance regressions when USE_ANGLE=1

[James Darpinian]

After this patch plus a couple of upstream changes I'm working on in ANGLE, setting USE_ANGLE=1 on Mac fixes a bunch of WebGL conformance tests and causes no new test regressions.

[WebKit Commit Bot]

Comment on attachment 380163 [details]
Fix WebGL 1 conformance regressions when USE_ANGLE=1

Clearing flags on attachment: 380163

Committed r250697: <https://trac.webkit.org/changeset/250697>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55972310>

[Darin Adler]

Comment on attachment 380163 [details]
Fix WebGL 1 conformance regressions when USE_ANGLE=1

View in context: https://bugs.webkit.org/attachment.cgi?id=380163&action=review

> Source/WebCore/html/canvas/WebGLDebugShaders.cpp:54
>      if (m_context.isContextLost())
>          return String();

Since this function can no longer return null, it doesn’t make sense to return a null string here. Before the change to the bindings, this would turn into a JavaScript null, so this line of code may have had a valuable effect. We should consider returning an empty string here. Or perhaps removing this code entirely as long as the validateWebGLObject function is guaranteed to return false when the context is lost.