RESOLVED FIXED 202530
[GTK] WebAutomation: make setWindowRect synchronous 
https://bugs.webkit.org/show_bug.cgi?id=202530
Summary [GTK] WebAutomation: make setWindowRect synchronous
Carlos Garcia Campos
Reported 2019-10-03 09:05:41 PDT
Move/resize window is asynchronous in GTK, but automation expects it to be synchronous so that get window rect after setting it always returns the value set.
Attachments
Patch (3.81 KB, patch)
2019-10-03 09:08 PDT, Carlos Garcia Campos 		clopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-10-03 09:08:15 PDT
Created attachment 380119 [details] Patch
EWS Watchlist
Comment 2 2019-10-03 09:09:07 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Alberto Lopez Perez
Comment 3 2019-10-03 09:26:38 PDT
Comment on attachment 380119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380119&action=review > Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp:156 > + if (geometry.x >= 0 && geometry.y >= 0) { curly braces are not needed around this if. > Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp:159 > + if (geometry.width > 0 && geometry.height > 0) { Same here.
Carlos Garcia Campos
Comment 4 2019-10-03 23:15:50 PDT
Committed r250707: <https://trac.webkit.org/changeset/250707>
Note You need to log in before you can comment on or make changes to this bug.