Bug 202498 - [iOS] When hit testing for a context menu interaction, do not consider whether the element is contenteditable
Summary: [iOS] When hit testing for a context menu interaction, do not consider whethe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-02 15:43 PDT by Andy Estes
Modified: 2019-10-02 21:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (12.74 KB, patch)
2019-10-02 16:06 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-10-02 15:43:31 PDT 
[iOS] When hit testing for a context menu interaction, do not consider whether the element is contenteditable
Comment 1 Andy Estes 2019-10-02 16:06:49 PDT 
Created attachment 380068 [details]
Patch
Comment 2 Tim Horton 2019-10-02 16:15:27 PDT 
Comment on attachment 380068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380068&action=review

> Source/WebCore/page/ios/FrameIOS.mm:271
> +#if !USE(UIKIT_EDITING)

Wut
Comment 3 Andy Estes 2019-10-02 16:18:34 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 380068 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380068&action=review
> 
> > Source/WebCore/page/ios/FrameIOS.mm:271
> > +#if !USE(UIKIT_EDITING)
> 
> Wut

#if PLATFORM(IOS_FAMILY)
#define USE_UIKIT_EDITING 1
...


Yeah, surely we don't need this USE() anymore.
Comment 4 Andy Estes 2019-10-02 21:11:14 PDT 
rdar://problem/54723131
Comment 5 Radar WebKit Bug Importer 2019-10-02 21:11:27 PDT Comment hidden (obsolete)
Comment 6 Radar WebKit Bug Importer 2019-10-02 21:11:28 PDT Comment hidden (obsolete)
Comment 7 WebKit Commit Bot 2019-10-02 21:54:00 PDT 
Comment on attachment 380068 [details]
Patch

Clearing flags on attachment: 380068

Committed r250642: <https://trac.webkit.org/changeset/250642>
Comment 8 WebKit Commit Bot 2019-10-02 21:54:02 PDT 
All reviewed patches have been landed.  Closing bug.