Bug 202493 - FTL OSR exit shouldn't bother updating get_by_id array profiles that have changed modes
Summary: FTL OSR exit shouldn't bother updating get_by_id array profiles that have cha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-02 14:04 PDT by Keith Miller
Modified: 2019-10-02 14:20 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.04 KB, patch)
2019-10-02 14:07 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (2.95 KB, patch)
2019-10-02 14:08 PDT, Keith Miller 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2019-10-02 14:04:47 PDT 
FTL OSR exit shouldn't bother updating get_by_id array profiles that have changed modes
Comment 1 Keith Miller 2019-10-02 14:07:16 PDT 
Created attachment 380057 [details]
Patch
Comment 2 Keith Miller 2019-10-02 14:08:12 PDT 
Created attachment 380058 [details]
Patch
Comment 3 Saam Barati 2019-10-02 14:12:10 PDT 
Comment on attachment 380058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380058&action=review

> Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:256
> +                if (instruction->opcodeID() == op_get_by_id) {

do you want to do the is<OpGetById> instead?
Comment 4 Keith Miller 2019-10-02 14:18:50 PDT 
Comment on attachment 380058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380058&action=review

>> Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:256
>> +                if (instruction->opcodeID() == op_get_by_id) {
> 
> do you want to do the is<OpGetById> instead?

Sure, why not.
Comment 5 Keith Miller 2019-10-02 14:19:42 PDT 
Committed r250629: <https://trac.webkit.org/changeset/250629>
Comment 6 Radar WebKit Bug Importer 2019-10-02 14:20:18 PDT 
<rdar://problem/55924336>
Comment 7 Radar WebKit Bug Importer 2019-10-02 14:20:19 PDT 
<rdar://problem/55924337>