Bug 202492 - DoubleToStringConverter::ToExponential() should null terminate its string.
Summary: DoubleToStringConverter::ToExponential() should null terminate its string.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-02 13:53 PDT by Mark Lam
Modified: 2019-10-02 20:21 PDT (History)
9 users (show)

See Also:

Attachments
proposed patch. (3.94 KB, patch)
2019-10-02 14:04 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-10-02 13:53:37 PDT 
<rdar://problem/55907708>
Comment 1 Mark Lam 2019-10-02 14:04:03 PDT 
Created attachment 380056 [details]
proposed patch.
Comment 2 Mark Lam 2019-10-02 15:34:59 PDT 
Comment on attachment 380056 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 3 WebKit Commit Bot 2019-10-02 16:21:04 PDT 
Comment on attachment 380056 [details]
proposed patch.

Clearing flags on attachment: 380056

Committed r250636: <https://trac.webkit.org/changeset/250636>
Comment 4 WebKit Commit Bot 2019-10-02 16:21:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Yusuke Suzuki 2019-10-02 20:21:00 PDT 
Is it better to upstream this change to https://github.com/google/double-conversion ?