Bug 202490 – CMake-built WebKit.framework should launch XPC services successfully

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

CMake-built WebKit.framework should launch XPC services successfully

[Alex Christensen]

Created attachment 380050 [details]
Patch

[Carlos Alberto Lopez Perez]

> https://trac.webkit.org/changeset/250625/webkit

This broke one of our bots of minimum dependencies:

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Ubuntu%20LTS%20%28Build%29/builds/25355/steps/compile-webkit/logs/stdio :
> CMake Error at Source/WebKit/CMakeLists.txt:423 (target_link_options):
>  Unknown CMake command "target_link_options".
>
>
> -- Configuring incomplete, errors occurred!

It looks like target_link_options is supported only since CMake 3.13

Ubuntu 18.04 LTS has cmake 3.10, which is what we require as minimum version on the main CMakeLists.txt.

Is it possible to re-work this patch to avoid using target_link_options? or if not, can be it only used by the Mac port?

[Alex Christensen]

Followup: http://trac.webkit.org/r250638

Would it be sufficient to put if (APPLE) around the call, or would that bot still fail?

[Konstantin Tokarev]

Comment on attachment 380050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380050&action=review

> Source/WebKit/CMakeLists.txt:423
> +target_link_options(WebKit PRIVATE ${WebKit_LINK_OPTIONS})

FWIW, you can add necessary options inside PlatformMac.cmake, as WebKit target is available there

[Yury Semikhatsky]

(In reply to Carlos Alberto Lopez Perez from comment #2)
> It looks like target_link_options is supported only since CMake 3.13
> 
> Ubuntu 18.04 LTS has cmake 3.10, which is what we require as minimum version
> on the main CMakeLists.txt.
> 
> Is it possible to re-work this patch to avoid using target_link_options? or
> if not, can be it only used by the Mac port?

+1. I'm using Ubuntu 18.04 LTS with cmake 3.10.2 and WebKit GTK doesn't build anymore.

[Carlos Alberto Lopez Perez]

(In reply to Alex Christensen from comment #3)
> Followup: http://trac.webkit.org/r250638
> 
> Would it be sufficient to put if (APPLE) around the call, or would that bot
> still fail?

Yes, that would be sufficient :)

[Yury Semikhatsky]

Created attachment 380124 [details]
Patch

[Konstantin Tokarev]

Comment on attachment 380124 [details]
Patch

I don't agree with this fix, for reasons mentioned above. Things specific to Mac port should go to PlatformMac.cmake, not spread around. Also, if (APPLE) condition will be true for WebKitGTK on macOS, which may have undesirable consequences.

[Konstantin Tokarev]

Created attachment 380137 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 380137 [details]
Patch

Yeah, this is better. btw, how can I build using cmake on Mac? build-webkit doesn't seem ti use it.

[Yury Semikhatsky]

Yeah, this is better. btw, how can I build using cmake on Mac? build-webkit doesn't seem ti use it.

[Konstantin Tokarev]

Do you want to build Mac port or GTK port? If former, try --cmake switch (at least it used to work in the past)

[Yury Semikhatsky]

(In reply to Konstantin Tokarev from comment #12)
> Do you want to build Mac port or GTK port? If former, try --cmake switch (at
> least it used to work in the past)

Thanks for the pointer. --cmake option seems to be missing in the output of build-webkit --help which is why I couldn't find it. I was thinking about building Mac port as I wasn't able to build GTK on Mac in the past for various dependency problems, not sure what state it is in.

[Carlos Alberto Lopez Perez]

Comment on attachment 380137 [details]
Patch

Yeah! much better. Thanks!

[Konstantin Tokarev]

Comment on attachment 380137 [details]
Patch

Clearing flags on attachment: 380137

Committed r250664: <https://trac.webkit.org/changeset/250664>

[Konstantin Tokarev]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55953736>