Bug 202487 – Web Inspector: remove `InspectorInstrumentationCookie`

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

All it does is create a shallow-copy of the `InstrumentingAgents` (it copies a pointer to the `InstrumentingAgents` object, so any of the pointers to the `InspectorAgent` that are contained therein are shared between each instance) and save the tracking `InspectorTimelineAgent`'s id (monotonically increasing integer).  All uses of `InspectorInstrumentationCookie` are local values, so there's no way that the `InspectorTimelineAgent` (or the id) could change in between an `InspectorInstrumentation::will*` and an `InspectorInstrumentation::did*`, as both the tracking state and id are controlled by the frontend and cannot "interrupt".

[Devin Rousso]

Created attachment 380048 [details]
Patch

[Matt Baker]

Comment on attachment 380048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380048&action=review

r=me, nice refactor.

> Source/WebCore/inspector/InspectorInstrumentation.cpp:401
> +        return;

Breaking out this early return is nice. :)

> Source/WebCore/inspector/InspectorInstrumentation.h:835
> +

There is an empty line after FAST_RETURN_IF_NO_FRONTENDS here, and below (843), but not elsewhere. We should be consistent.

[Devin Rousso]

Created attachment 380122 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 380122 [details]
Patch

Clearing flags on attachment: 380122

Committed r250672: <https://trac.webkit.org/changeset/250672>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55957063>

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/250672/webkit

broke inspector/timeline/timeline-recording.html

It is crashing on Mac debug and failing on Release.

I was able to reproduce the crashes by simply running the test on 250672 which crashes, and did not crash on 250668 which was the revision before it. cherry picked were in-between.

[Devin Rousso]

(In reply to Truitt Savell from comment #7)
> It looks like the changes in https://trac.webkit.org/changeset/250672/webkit
> 
> broke inspector/timeline/timeline-recording.html
> 
> It is crashing on Mac debug and failing on Release.
> 
> I was able to reproduce the crashes by simply running the test on 250672 which crashes, and did not crash on 250668 which was the revision before it. cherry picked were in-between.
I'm addressing this in <https://webkit.org/b/202713>.