Bug 202479 - Make DOMPoint a DOMLiveObject
Summary: Make DOMPoint a DOMLiveObject
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
: 201783 (view as bug list)
Depends on: 201782
Blocks: 191376
  Show dependency tree / graph
 
Reported: 2019-10-02 10:43 PDT by Said Abou-Hallawa
Modified: 2020-06-15 11:47 PDT (History)
17 users (show)

See Also:

Attachments
Patch (98.50 KB, patch)
2019-10-02 10:57 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (102.21 KB, patch)
2019-10-03 10:02 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (102.88 KB, patch)
2019-10-03 10:38 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (102.90 KB, patch)
2019-10-03 10:49 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (102.90 KB, patch)
2019-10-03 11:52 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch for review (32.16 KB, patch)
2019-10-03 12:55 PDT, Said Abou-Hallawa 		ysuzuki: review-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-10-02 10:43:33 PDT 
In order to replace SVGPoint by DOMPoint, DOMPoint has to communicate changes with its observer. Changing DOMPoint will not be allowed if the observer is read-only.
Comment 1 Said Abou-Hallawa 2019-10-02 10:57:53 PDT 
Created attachment 380037 [details]
Patch
Comment 2 Said Abou-Hallawa 2019-10-03 10:02:37 PDT 
Created attachment 380127 [details]
Patch
Comment 3 Said Abou-Hallawa 2019-10-03 10:38:12 PDT 
Created attachment 380130 [details]
Patch
Comment 4 Said Abou-Hallawa 2019-10-03 10:49:18 PDT 
Created attachment 380133 [details]
Patch
Comment 5 Said Abou-Hallawa 2019-10-03 11:52:31 PDT 
Created attachment 380147 [details]
Patch
Comment 6 Yusuke Suzuki 2019-10-03 12:03:50 PDT 
Comment on attachment 380147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380147&action=review

> Source/WebCore/dom/DOMPoint.h:98
> +static_assert(sizeof(DOMPoint) == sizeof(DOMPointReadOnly) + sizeof(DOMLiveProperty), "");

Let's remove this. This `static_assert` ensures that it is OK that DOMPoint shares the same IsoHeap with DOMPointReadOnly.
But now, this patch changes DOMPoint, and now they are not the same layout. This patch introduced IsoHeap for DOMPoint (this is mandatory), and then, this static_assert is not necessary.
Comment 7 Said Abou-Hallawa 2019-10-03 12:55:14 PDT 
Created attachment 380154 [details]
Patch for review
Comment 8 Said Abou-Hallawa 2019-10-07 17:23:58 PDT 
*** Bug 201783 has been marked as a duplicate of this bug. ***
Comment 9 Yusuke Suzuki 2020-06-15 10:50:42 PDT 
Comment on attachment 380154 [details]
Patch for review

r- because applying the patch does not work. Looks like rebase is necessary.
Comment 10 Said Abou-Hallawa 2020-06-15 11:47:02 PDT 
Replacing SVGRect/SVGPoint/SVGMatrix by DOM equivalents was reverted in the specs: https://github.com/w3c/svgwg/issues/706. So this bug is now invalid and the attached patch should not be considered.