Bug 202466 - Python 3: Add support in webkitpy.common.net.buildbot
Summary: Python 3: Add support in webkitpy.common.net.buildbot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-02 08:40 PDT by Jonathan Bedard
Modified: 2019-10-17 14:40 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.45 KB, patch)
2019-10-15 14:49 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-10-02 08:40:27 PDT 
Add webkitpy.common.net.buildbot to test-webkitpy-python3
Comment 1 Jonathan Bedard 2019-10-15 14:49:58 PDT 
Created attachment 381023 [details]
Patch
Comment 2 Stephanie Lewis 2019-10-17 14:01:57 PDT 
Comment on attachment 381023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381023&action=review

> Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:338
> +        rendered = decode_for(cell.renderContents(), str)

why is this different
Comment 3 Jonathan Bedard 2019-10-17 14:07:54 PDT 
Comment on attachment 381023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381023&action=review

>> Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:338
>> +        rendered = decode_for(cell.renderContents(), str)
> 
> why is this different

For some reason, BeautifulSoup and bs4 render cells differently. In fairness, the new way of rendering things is more correct, but that's basically the difference.

The decode_for call is important because in Python3, renderContents() returns raw bytes, we need string (aka, unicode in Python 3)
Comment 4 Stephanie Lewis 2019-10-17 14:21:09 PDT 
maybe add a comment about beautiful soup then.
Comment 5 Jonathan Bedard 2019-10-17 14:39:29 PDT 
Committed r251259: <https://trac.webkit.org/changeset/251259>
Comment 6 Radar WebKit Bug Importer 2019-10-17 14:40:17 PDT 
<rdar://problem/56386174>