Bug 20246 – Implement RenderTheme::systemColor() for Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Eric Roman]

CSS system colors (http://msdn.microsoft.com/en-us/library/aa358804.aspx) are hard coded constants on Windows Safari. Instead these should query windows.

[Eric Roman]

Created attachment 22590 [details]
Call through to GetSysColor() for RenderThemeSafari::systemColor()

-I think I need to do a parallel change to RenderThemeWin.cpp, but not sure.
-Not sure what sort of test to write for this, since the expected value will depend on the theme.

[Eric Seidel (no email)]

Comment on attachment 22590 [details]
Call through to GetSysColor() for RenderThemeSafari::systemColor()

Looks OK.  The switch style is probably wrong by WebKit standards.  I'd almost consider using a HashMap here, except that'd be a bunch of memory on the heap for no real need.

I wonder if we need any kind of caching here?  Color does some amount of caching, but I don't think that applies here.

Adam Roben should comment.

[Dave Hyatt]

Comment on attachment 22590 [details]
Call through to GetSysColor() for RenderThemeSafari::systemColor()

The point of RenderThemeSafari is to match the look of OS X and not the look of Windows.

[Dave Hyatt]

RenderThemeWin (if someone used it) would be more suitable for this patch, since that theme is about matching the native Windows look.

[Eric Roman]

Created attachment 22611 [details]
I see. Moved the change from RenderThemeSafari to RenderThemeWin.

[Dave Hyatt]

Comment on attachment 22611 [details]
I see. Moved the change from RenderThemeSafari to RenderThemeWin.

r=me

[Darin Adler]

http://trac.webkit.org/changeset/37537