Bug 20245 - WinLauncher does not start in WebKit-debug right out of the box.
Summary: WinLauncher does not start in WebKit-debug right out of the box.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-31 14:24 PDT by Stefan Landvogt
Modified: 2008-07-31 15:13 PDT (History)
0 users

See Also:


Attachments
Just following arobens directions for fixing WinLauncher. (730 bytes, patch)
2008-07-31 14:26 PDT, Stefan Landvogt
aroben: review-
Details | Formatted Diff | Diff
Adding the changes to "All Configurations" (730 bytes, text/plain)
2008-07-31 14:39 PDT, Stefan Landvogt
no flags Details
Adding the properties to "all configurations" and add changelog entry (1.36 KB, patch)
2008-07-31 14:50 PDT, Stefan Landvogt
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Landvogt 2008-07-31 14:24:17 PDT
I build WebKit-debug and to verify that the WebKit.dll is fine, I try to start WinLauncher. This fails at 
HRESULT hr = CoCreateInstance(CLSID_WebView, 0, CLSCTX_ALL, IID_IWebView, (void**)&gWebView);
where hr is returning some error code.

With help from aroben I tested the following patch, which worked on my system after a clean build but not after a rebuild of the WinLauncher solution.
Comment 1 Stefan Landvogt 2008-07-31 14:26:40 PDT
Created attachment 22587 [details]
Just following arobens directions for fixing WinLauncher.
Comment 2 Adam Roben (:aroben) 2008-07-31 14:29:41 PDT
Comment on attachment 22587 [details]
Just following arobens directions for fixing WinLauncher.

Thanks for the patch!

Two changes are needed before we can land this:

1. The change you made to the project file needs to be made for all configurations. You should choose "All Configurations" from the "Configuration" drop-down in the "Project Properties" dialog, then make the change.

2. You need to write a ChangeLog entry. See <http://webkit.org/coding/contributing.html> for instructions on how to do so.
Comment 3 Stefan Landvogt 2008-07-31 14:39:08 PDT
Created attachment 22588 [details]
Adding the changes to "All Configurations"
Comment 4 Stefan Landvogt 2008-07-31 14:50:49 PDT
Created attachment 22589 [details]
Adding the properties to "all configurations" and add changelog entry
Comment 5 Adam Roben (:aroben) 2008-07-31 15:10:00 PDT
Comment on attachment 22589 [details]
Adding the properties to "all configurations" and add changelog entry

r=me

Normally in ChangeLogs we mention the bug that's being fixed, like this:

Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of the box
<https://bugs.webkit.org/show_bug.cgi?id=20245>

Reviewed by NOBODY (OOPS!)

I can make this change before landing the patch.

Thanks again!
Comment 6 Adam Roben (:aroben) 2008-07-31 15:13:11 PDT
Landed in r35500