Bug 20245 – WinLauncher does not start in WebKit-debug right out of the box.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Stefan Landvogt]

I build WebKit-debug and to verify that the WebKit.dll is fine, I try to start WinLauncher. This fails at 
HRESULT hr = CoCreateInstance(CLSID_WebView, 0, CLSCTX_ALL, IID_IWebView, (void**)&gWebView);
where hr is returning some error code.

With help from aroben I tested the following patch, which worked on my system after a clean build but not after a rebuild of the WinLauncher solution.

[Stefan Landvogt]

Created attachment 22587 [details]
Just following arobens directions for fixing WinLauncher.

[Adam Roben (:aroben)]

Comment on attachment 22587 [details]
Just following arobens directions for fixing WinLauncher.

Thanks for the patch!

Two changes are needed before we can land this:

1. The change you made to the project file needs to be made for all configurations. You should choose "All Configurations" from the "Configuration" drop-down in the "Project Properties" dialog, then make the change.

2. You need to write a ChangeLog entry. See <http://webkit.org/coding/contributing.html> for instructions on how to do so.

[Stefan Landvogt]

Created attachment 22588 [details]
Adding the changes to "All Configurations"

[Stefan Landvogt]

Created attachment 22589 [details]
Adding the properties to "all configurations" and add changelog entry

[Adam Roben (:aroben)]

Comment on attachment 22589 [details]
Adding the properties to "all configurations" and add changelog entry

r=me

Normally in ChangeLogs we mention the bug that's being fixed, like this:

Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of the box
<https://bugs.webkit.org/show_bug.cgi?id=20245>

Reviewed by NOBODY (OOPS!)

I can make this change before landing the patch.

Thanks again!

[Adam Roben (:aroben)]

Landed in r35500