RESOLVED FIXED202444
Clean up some includes to make the build a bit faster: InspectorInstrumentation 
https://bugs.webkit.org/show_bug.cgi?id=202444
Summary Clean up some includes to make the build a bit faster: InspectorInstrumentation
Tim Horton
Reported 2019-10-01 20:12:41 PDT
Clean up some includes to make the build a bit faster
Attachments
Patch (16.46 KB, patch)
2019-10-01 20:13 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (16.75 KB, patch)
2019-10-01 20:17 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (16.77 KB, patch)
2019-10-01 20:26 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (17.27 KB, patch)
2019-10-01 20:29 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (17.92 KB, patch)
2019-10-01 20:46 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (17.38 KB, patch)
2019-10-01 21:20 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (17.96 KB, patch)
2019-10-01 21:33 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-10-01 20:13:40 PDT
Created attachment 379986 [details] Patch
Tim Horton
Comment 2 2019-10-01 20:17:44 PDT
Created attachment 379987 [details] Patch
Tim Horton
Comment 3 2019-10-01 20:26:03 PDT
Created attachment 379988 [details] Patch
Geoffrey Garen
Comment 4 2019-10-01 20:29:34 PDT
Comment on attachment 379988 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379988&action=review r=me! > Source/WebCore/inspector/InspectorInstrumentation.h:-53 > -#include "InspectorController.h" > #include "InspectorInstrumentationCookie.h" > #include "InspectorInstrumentationPublic.h" > -#include "OffscreenCanvas.h" > #include "Page.h" > #include "StorageArea.h" > -#include "WorkerGlobalScope.h" > -#include "WorkerInspectorController.h" > -#include <JavaScriptCore/JSCInlines.h> Which one of these was worth 80%???
Tim Horton
Comment 5 2019-10-01 20:29:53 PDT
Created attachment 379989 [details] Patch
Tim Horton
Comment 6 2019-10-01 20:30:32 PDT
You need all of them! They all somehow or another get to bad JSC things :D
Tim Horton
Comment 7 2019-10-01 20:31:38 PDT
(In reply to Tim Horton from comment #6) > You need all of them! They all somehow or another get to bad JSC things :D Also the removal of ImageBitmap (which gets JSDOMPromise* IIRC) is like half of it.
Tim Horton
Comment 8 2019-10-01 20:46:48 PDT
Created attachment 379992 [details] Patch
Tim Horton
Comment 9 2019-10-01 21:20:16 PDT
Created attachment 379993 [details] Patch
Tim Horton
Comment 10 2019-10-01 21:33:17 PDT
Created attachment 379994 [details] Patch
Tim Horton
Comment 11 2019-10-01 23:45:43 PDT
https://trac.webkit.org/changeset/250595/webkit
Radar WebKit Bug Importer
Comment 12 2019-10-01 23:46:18 PDT
<rdar://problem/55902055>
Antoine Quint
Comment 13 2019-10-02 04:05:01 PDT
There was a little bit of build breakage (at least internal macOS builds) which I fixed in r250600.
Tim Horton
Comment 15 2019-10-02 09:11:17 PDT
(In reply to Antoine Quint from comment #13) > There was a little bit of build breakage (at least internal macOS builds) > which I fixed in r250600. Thank you! (In reply to Truitt Savell from comment #14) > It looks like this patch https://trac.webkit.org/changeset/250595/webkit > > broke the open source windows builders: > https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/ > builds/7182 > > Log: > https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/ > builds/7182/steps/compile-webkit/logs/stdio Will fix shortly.
Tim Horton
Comment 16 2019-10-02 10:57:47 PDT
Hmm, bots do not think that this was much of a win. Will do more testing and see what I missed. I don't understand how we can mismatch with the new approach :D
Note You need to log in before you can comment on or make changes to this bug.