Bug 202440 - Properly mark canceled resources in NetworkActivityTracker
Summary: Properly mark canceled resources in NetworkActivityTracker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-01 16:53 PDT by Keith Rollin
Modified: 2019-10-02 10:43 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.16 KB, patch)
2019-10-01 16:56 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-10-01 16:53:06 PDT 
The nw_activity facility tracking resource loads did not originally have support for reporting resources that were canceled. It now has that support (since late MacOS 14-aligned SDKs), so add support for it in NetworkActivityTracker and use it in places where we were previously reporting the status of canceled resources as "None".
Comment 1 Keith Rollin 2019-10-01 16:53:17 PDT 
<rdar://problem/55843651>
Comment 2 Keith Rollin 2019-10-01 16:56:56 PDT 
Created attachment 379969 [details]
Patch
Comment 3 Brent Fulgham 2019-10-02 09:23:19 PDT 
Comment on attachment 379969 [details]
Patch

Looks good. r=me.
Comment 4 WebKit Commit Bot 2019-10-02 10:43:08 PDT 
Comment on attachment 379969 [details]
Patch

Clearing flags on attachment: 379969

Committed r250614: <https://trac.webkit.org/changeset/250614>
Comment 5 WebKit Commit Bot 2019-10-02 10:43:10 PDT 
All reviewed patches have been landed.  Closing bug.