Bug 202435 – Storage Access API: document.hasStorageAccess() should return true when the cookie policy allows access

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Wilander]

WebKit's Storage Access API implementation has so far only looked at whether ITP is blocking cookie access or not. However, the default cookie policy is still in effect underneath ITP. document.hasStorageAccess() should return true if the third-party a) is not classified by ITP and b) has cookies which implies it can use cookies as third-party according to the default cookie policy.

[John Wilander]

<rdar://problem/55718526>

[John Wilander]

Created attachment 379955 [details]
Patch

[John Wilander]

Created attachment 379962 [details]
Patch

[Brent Fulgham]

Comment on attachment 379962 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379962&action=review

Looks reasonable. I think you left some partially-written code in one section. If r=me (ews)

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:448
> +    }

This little section seems unneeded.

[John Wilander]

(In reply to Brent Fulgham from comment #4)
> Comment on attachment 379962 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=379962&action=review
> 
> Looks reasonable. I think you left some partially-written code in one
> section. If r=me (ews)
> 
> > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:448
> > +    }
> 
> This little section seems unneeded.

Oops. Good catch. Ugly.

Thanks! Will wait for EWS.

[John Wilander]

Created attachment 379974 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 379974 [details]
Patch for landing

Clearing flags on attachment: 379974

Committed r250589: <https://trac.webkit.org/changeset/250589>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.