Bug 202429 – [Test262] 8 tests failing after import for updated tests in r250571

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: WebCore JavaScript

[Matt Lewis]

The following test are failing on Debug and release for Test262:

test/built-ins/Array/proto-from-ctor-realm.js
test/built-ins/Array/proto-from-ctor-realm.js
test/built-ins/FinalizationGroup/prototype/cleanupSome/gc-cleanup-not-prevented-with-wr-deref.js
test/built-ins/FinalizationGroup/prototype/cleanupSome/gc-cleanup-not-prevented-with-wr-deref.js
test/built-ins/Object/proto-from-ctor.js
test/built-ins/Object/proto-from-ctor.js
test/intl402/DateTimeFormat/constructor-options-throwing-getters-quarter.js
test/intl402/DateTimeFormat/constructor-options-throwing-getters-quarter.js

https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20Test262%20%28Tests%29/builds/5157/steps/test262-test/logs/stdio
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20Test262%20%28Tests%29/builds/5157

Failed after https://trac.webkit.org/changeset/250571/webkit

[Matt Lewis]

FAIL test/built-ins/Array/proto-from-ctor-realm.js (default)
Full Output:
Exception: Test262Error: Expected SameValue(«», «») to be true

FAIL test/built-ins/Array/proto-from-ctor-realm.js (strict mode)
Full Output:
Exception: Test262Error: Expected SameValue(«», «») to be true

FAIL test/built-ins/FinalizationGroup/prototype/cleanupSome/gc-cleanup-not-prevented-with-wr-deref.js (default)
Full Output:
Exception: ReferenceError: Can't find variable: FinalizationGroup
global code@/Volumes/Data/slave/highsierra-debug-tests-test262/build/JSTests/test262/test/built-ins/FinalizationGroup/prototype/cleanupSome/gc-cleanup-not-prevented-with-wr-deref.js:30:31

FAIL test/built-ins/FinalizationGroup/prototype/cleanupSome/gc-cleanup-not-prevented-with-wr-deref.js (strict mode)
Full Output:
Exception: ReferenceError: Can't find variable: FinalizationGroup
global code@/Volumes/Data/slave/highsierra-debug-tests-test262/build/JSTests/test262/test/built-ins/FinalizationGroup/prototype/cleanupSome/gc-cleanup-not-prevented-with-wr-deref.js:31:31

FAIL test/built-ins/Object/proto-from-ctor.js (default)
Full Output:
Exception: Test262Error: Expected SameValue(«[object Object]», «[object Object]») to be true

FAIL test/built-ins/Object/proto-from-ctor.js (strict mode)
Full Output:
Exception: Test262Error: Expected SameValue(«[object Object]», «[object Object]») to be true

FAIL test/intl402/DateTimeFormat/constructor-options-throwing-getters-quarter.js (default)
Full Output:
Exception: Test262Error: Exception from quarter getter should be propagated Expected a CustomError to be thrown but no exception was thrown at all

FAIL test/intl402/DateTimeFormat/constructor-options-throwing-getters-quarter.js (strict mode)
Full Output:
Exception: Test262Error: Exception from quarter getter should be propagated Expected a CustomError to be thrown but no exception was thrown at all

[Radar WebKit Bug Importer]

<rdar://problem/55887394>

[Radar WebKit Bug Importer]

<rdar://problem/55887396>

[Keith Miller]

Created attachment 380022 [details]
Patch

[Keith Miller]

Created attachment 380023 [details]
Patch

[Alexey Shvayka]

Currently, expectations.yaml and imported test262 files are slightly out-of-sync. For example, "Object/proto-from-ctor.js" was recently renamed to "Object/proto-from-ctor-realm.js" and "Array/proto-from-ctor-realm.js" was removed.

Proposed patch changes expectations.yaml to match with files that were imported with conflict resolution issues, while we could rather import the tests again and fix all the renames.

Please assign this bug on me if a patch is welcome.

[Ross Kirsling]

(In reply to Alexey Shvayka from comment #6)
> Currently, expectations.yaml and imported test262 files are slightly
> out-of-sync. For example, "Object/proto-from-ctor.js" was recently renamed
> to "Object/proto-from-ctor-realm.js" and "Array/proto-from-ctor-realm.js"
> was removed.
> 
> Proposed patch changes expectations.yaml to match with files that were
> imported with conflict resolution issues, while we could rather import the
> tests again and fix all the renames.
> 
> Please assign this bug on me if a patch is welcome.

Ack, sorry for not replying to your comment earlier, Alexey.

I've done another test262 import in r250842, so this should be settled now.