Bug 202408 - [ews] Add method to retry a build using Buildbot API
Summary: [ews] Add method to retry a build using Buildbot API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-01 09:13 PDT by Aakash Jain
Modified: 2019-10-01 12:09 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.50 KB, patch)
2019-10-01 09:20 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-10-01 09:13:50 PDT
Add method to retry a build using Buildbot API.
Comment 1 Aakash Jain 2019-10-01 09:20:51 PDT
Created attachment 379910 [details]
Patch
Comment 2 Aakash Jain 2019-10-01 10:24:07 PDT
Tested on uat instance.
Comment 3 Jonathan Bedard 2019-10-01 10:35:07 PDT
Comment on attachment 379910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379910&action=review

> Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:28
> +import requests

How are we guaranteeing that this is installed?

> Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:104
> +    def retry_build(cls, builder_id, build_number):

Who is going to call this and what is our plan for testing?
Comment 4 Aakash Jain 2019-10-01 11:20:23 PDT
> How are we guaranteeing that this is installed?
Through separate ansible configuration.
> 
> > Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:104
> > +    def retry_build(cls, builder_id, build_number):
> 
> Who is going to call this and what is our plan for testing?
A new API endpoint would be added to retry the (failed builds of) patch, that endpoint would use this method. I am currently testing that, and would post a patch for it soon.
Comment 5 WebKit Commit Bot 2019-10-01 12:06:37 PDT
Comment on attachment 379910 [details]
Patch

Clearing flags on attachment: 379910

Committed r250572: <https://trac.webkit.org/changeset/250572>
Comment 6 WebKit Commit Bot 2019-10-01 12:06:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-10-01 12:09:45 PDT
<rdar://problem/55885172>