This patch cleans up a few errors in the Path and ImageData code causing some test failures.
Created attachment 379871 [details] Patch
Comment on attachment 379871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379871&action=review > Source/WebCore/platform/graphics/win/Direct2DOperations.cpp:714 > + auto transformedRectToClear = transform.mapRect(rectToClear); mapRect returns a bounding rect if transform is rotated. Do you need to use fillPath? Path path; path.addRect(rect); fillPath(platformContext, path, Color::transparent);
Comment on attachment 379871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379871&action=review >> Source/WebCore/platform/graphics/win/Direct2DOperations.cpp:714 >> + auto transformedRectToClear = transform.mapRect(rectToClear); > > mapRect returns a bounding rect if transform is rotated. Do you need to use fillPath? > Path path; > path.addRect(rect); > fillPath(platformContext, path, Color::transparent); Oh! Good point. I'll simplify the high-level Path commands to the appropriate D2D set for this use case, and only do this when we are not translating. It seems like this path is only needed if the transform is not axis-aligned.
Created attachment 379920 [details] Patch
Before this change: 681 / 775 Pass After this change: 684 / 775 Pass
Comment on attachment 379920 [details] Patch Clearing flags on attachment: 379920 Committed r250581: <https://trac.webkit.org/changeset/250581>
All reviewed patches have been landed. Closing bug.
<rdar://problem/55889950>