Bug 202376 - Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finished loading or failed to load
Summary: Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-30 15:38 PDT by Devin Rousso
Modified: 2019-10-07 21:35 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.30 KB, patch)
2019-09-30 15:48 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-09-30 15:38:20 PDT
.
Comment 1 Devin Rousso 2019-09-30 15:48:42 PDT
Created attachment 379847 [details]
Patch
Comment 2 Matt Baker 2019-10-07 16:47:20 PDT
Comment on attachment 379847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379847&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js:172
> +            this.status = null;

So `supportsScriptBlackboxing` can change from true to false?
Comment 3 Devin Rousso 2019-10-07 20:48:27 PDT
Comment on attachment 379847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379847&action=review

>> Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js:172
>> +            this.status = null;
> 
> So `supportsScriptBlackboxing` can change from true to false?

I don't think so, but it looks like it's possible for the finished "state" of a `WI.Resource` to be reverted due to some interleaving of Page and Network commands (`WI.Resource.prototype.revertMarkAsFinished`).
Comment 4 WebKit Commit Bot 2019-10-07 21:35:00 PDT
Comment on attachment 379847 [details]
Patch

Clearing flags on attachment: 379847

Committed r250813: <https://trac.webkit.org/changeset/250813>
Comment 5 WebKit Commit Bot 2019-10-07 21:35:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-10-07 21:35:13 PDT
<rdar://problem/56062050>