Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finished loading or failed to load

[Devin Rousso]

.

[Devin Rousso]

Created attachment 379847 [details]
Patch

[Matt Baker]

Comment on attachment 379847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379847&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js:172
> +            this.status = null;

So `supportsScriptBlackboxing` can change from true to false?

[Devin Rousso]

Comment on attachment 379847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379847&action=review

>> Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js:172
>> +            this.status = null;
> 
> So `supportsScriptBlackboxing` can change from true to false?

I don't think so, but it looks like it's possible for the finished "state" of a `WI.Resource` to be reverted due to some interleaving of Page and Network commands (`WI.Resource.prototype.revertMarkAsFinished`).

[WebKit Commit Bot]

Comment on attachment 379847 [details]
Patch

Clearing flags on attachment: 379847

Committed r250813: <https://trac.webkit.org/changeset/250813>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56062050>