WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
202376
Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finished loading or failed to load
https://bugs.webkit.org/show_bug.cgi?id=202376
Summary
Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finis...
Devin Rousso
Reported
2019-09-30 15:38:20 PDT
.
Attachments
Patch
(2.30 KB, patch)
2019-09-30 15:48 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2019-09-30 15:48:42 PDT
Created
attachment 379847
[details]
Patch
Matt Baker
Comment 2
2019-10-07 16:47:20 PDT
Comment on
attachment 379847
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=379847&action=review
r=me
> Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js:172 > + this.status = null;
So `supportsScriptBlackboxing` can change from true to false?
Devin Rousso
Comment 3
2019-10-07 20:48:27 PDT
Comment on
attachment 379847
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=379847&action=review
>> Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js:172 >> + this.status = null; > > So `supportsScriptBlackboxing` can change from true to false?
I don't think so, but it looks like it's possible for the finished "state" of a `WI.Resource` to be reverted due to some interleaving of Page and Network commands (`WI.Resource.prototype.revertMarkAsFinished`).
WebKit Commit Bot
Comment 4
2019-10-07 21:35:00 PDT
Comment on
attachment 379847
[details]
Patch Clearing flags on attachment: 379847 Committed
r250813
: <
https://trac.webkit.org/changeset/250813
>
WebKit Commit Bot
Comment 5
2019-10-07 21:35:02 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-10-07 21:35:13 PDT
<
rdar://problem/56062050
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug