Bug 202370 – Allow pages using EventSource to enter the back/forward cache

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Allow pages using EventSource to enter the back/forward cache.

[Chris Dumez]

<rdar://problem/55853142>

[Chris Dumez]

Created attachment 379853 [details]
Patch

[Chris Dumez]

Created attachment 379904 [details]
Patch

[Chris Dumez]

Created attachment 379931 [details]
Patch

[Chris Dumez]

Created attachment 379936 [details]
Patch

[Chris Dumez]

Created attachment 379950 [details]
Patch

[Chris Dumez]

Patch is ready for review.

[Chris Dumez]

ping review?

[Geoffrey Garen]

Comment on attachment 379950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379950&action=review

r=me

> Source/WebCore/page/EventSource.cpp:427
> +    if (std::exchange(m_shouldDispatchErrorEventOnResume, false)) {
> +        scriptExecutionContext()->postTask([this, pendingActivity = makePendingActivity(*this)](ScriptExecutionContext&) {
> +            if (!isContextStopped())
> +                dispatchErrorEvent();
> +        });

Would it be crazy just to silently reconnect instead?

[Chris Dumez]

Comment on attachment 379950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379950&action=review

>> Source/WebCore/page/EventSource.cpp:427
>> +        });
> 
> Would it be crazy just to silently reconnect instead?

I can give it a shot. It would be nice.

[Chris Dumez]

Created attachment 380268 [details]
Patch

[Chris Dumez]

Requesting review again since I changed the approach to reconnect the EventSource when restoring from page cache.

[Geoffrey Garen]

Comment on attachment 380268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380268&action=review

r=me

> Source/WebCore/page/EventSource.cpp:429
> +                scheduleReconnect();

Shiny! :P

[WebKit Commit Bot]

Comment on attachment 380268 [details]
Patch

Clearing flags on attachment: 380268

Committed r250761: <https://trac.webkit.org/changeset/250761>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.