Bug 202350 - [Mac] Layout Test imported/w3c/web-platform-tests/fetch/api/redirect/redirect-location.any.html fails
Summary: [Mac] Layout Test imported/w3c/web-platform-tests/fetch/api/redirect/redirect...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-28 12:37 PDT by Rob Buis
Modified: 2019-10-01 11:52 PDT (History)
9 users (show)

See Also:

Attachments
Patch (24.95 KB, patch)
2019-09-28 12:41 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (26.94 KB, patch)
2019-09-29 03:12 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (27.38 KB, patch)
2019-09-29 08:36 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2019-09-28 12:37:40 PDT 
Layout Test imported/w3c/web-platform-tests/fetch/api/redirect/redirect-location.any.html fails.
Comment 1 Rob Buis 2019-09-28 12:41:16 PDT 
Created attachment 379792 [details]
Patch
Comment 2 Rob Buis 2019-09-29 03:12:38 PDT 
Created attachment 379808 [details]
Patch
Comment 3 Rob Buis 2019-09-29 08:36:10 PDT 
Created attachment 379811 [details]
Patch
Comment 4 Alex Christensen 2019-09-30 07:11:00 PDT 
Comment on attachment 379811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379811&action=review

> Source/WebCore/loader/SubresourceLoader.cpp:394
> +            ResourceLoader::didReceiveResponse(opaqueRedirectedResponse, [completionHandlerCaller = WTFMove(completionHandlerCaller)] { });

You could also do completionHandlerCaller.release()
Comment 5 WebKit Commit Bot 2019-10-01 11:51:12 PDT 
Comment on attachment 379811 [details]
Patch

Clearing flags on attachment: 379811

Committed r250570: <https://trac.webkit.org/changeset/250570>
Comment 6 WebKit Commit Bot 2019-10-01 11:51:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-10-01 11:52:18 PDT 
<rdar://problem/55884518>