Bug 202349 - [GTK][WPE] Fix non-unified build issue caused by r250440
Summary: [GTK][WPE] Fix non-unified build issue caused by r250440
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-28 12:30 PDT by Adrian Perez
Modified: 2019-09-28 17:49 PDT (History)
12 users (show)

See Also:

Attachments
Patch (1.19 KB, patch)
2019-09-28 12:32 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2019-09-28 12:30:39 PDT 
This one was introduced by r250440:

../Source/JavaScriptCore/dfg/DFGOSRExit.cpp:524:47: error: use of undeclared identifier 'OpGetById'; did you mean 'GetById'?
            bool doProfile = !instruction->is<OpGetById>() || instruction->as<OpGetById>().metadata(profiledCodeBlock).m_modeMetadata.mode == GetByIdMode::ArrayLength;
                                              ^~~~~~~~~
                                              GetById
Comment 1 Adrian Perez 2019-09-28 12:32:08 PDT 
Created attachment 379791 [details]
Patch
Comment 2 Mark Lam 2019-09-28 17:25:39 PDT 
Comment on attachment 379791 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-09-28 17:48:33 PDT 
Comment on attachment 379791 [details]
Patch

Clearing flags on attachment: 379791

Committed r250486: <https://trac.webkit.org/changeset/250486>
Comment 4 WebKit Commit Bot 2019-09-28 17:48:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-09-28 17:49:18 PDT 
<rdar://problem/55812379>