Bug 202335 - [Experiment][iOS] Add temporary HTTP header to distinguish iPads for requests to Google
Summary: [Experiment][iOS] Add temporary HTTP header to distinguish iPads for requests...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 202367
Blocks:
  Show dependency treegraph
 
Reported: 2019-09-27 15:36 PDT by Chris Dumez
Modified: 2019-09-30 12:04 PDT (History)
11 users (show)

See Also:


Attachments
Patch (2.76 KB, patch)
2019-09-27 16:23 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (2.90 KB, patch)
2019-09-27 16:42 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-27 15:36:55 PDT
Add temporary HTTP header to distinguish device types for requests to Google as an experiment.
Comment 1 Chris Dumez 2019-09-27 15:37:10 PDT
<rdar://problem/55790994>
Comment 2 Chris Dumez 2019-09-27 16:23:03 PDT
Created attachment 379772 [details]
Patch
Comment 3 Chris Dumez 2019-09-27 16:42:21 PDT
Created attachment 379774 [details]
Patch
Comment 4 Maciej Stachowiak 2019-09-28 12:35:02 PDT
Comment on attachment 379774 [details]
Patch

Code change looks good. Though there's still some debate over whether we should do this, I think it would be good to land and then discuss whether to change what we are doing, given the short timeline.
Comment 5 Chris Dumez 2019-09-28 14:32:57 PDT
Comment on attachment 379774 [details]
Patch

Thanks.
Comment 6 Chris Dumez 2019-09-28 14:38:18 PDT
Comment on attachment 379774 [details]
Patch

Clearing flags on attachment: 379774

Committed r250483: <https://trac.webkit.org/changeset/250483>
Comment 7 Chris Dumez 2019-09-28 14:38:20 PDT
All reviewed patches have been landed.  Closing bug.