Bug 202330 - [JSC] Keep JSString::value(ExecState*)'s result as String instead of `const String&`
Summary: [JSC] Keep JSString::value(ExecState*)'s result as String instead of `const S...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-27 13:28 PDT by Yusuke Suzuki
Modified: 2019-09-27 20:40 PDT (History)
7 users (show)

See Also:


Attachments
Patch (11.59 KB, patch)
2019-09-27 14:01 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (12.03 KB, patch)
2019-09-27 14:04 PDT, Yusuke Suzuki
saam: review+
Details | Formatted Diff | Diff
Patch (12.04 KB, patch)
2019-09-27 14:14 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-09-27 13:28:22 PDT
[JSC] Keep JSString::value(ExecState*)'s result as String instead of `const String&`
Comment 1 Yusuke Suzuki 2019-09-27 14:01:39 PDT
Created attachment 379762 [details]
Patch
Comment 2 Yusuke Suzuki 2019-09-27 14:04:42 PDT
Created attachment 379763 [details]
Patch
Comment 3 Mark Lam 2019-09-27 14:11:25 PDT
Comment on attachment 379763 [details]
Patch

r=me too if jsc tests pass with a debug build.  The reason is because you added a new ThrowScope.  Need to make sure that there are no new exception check validation failures.
Comment 4 Yusuke Suzuki 2019-09-27 14:14:20 PDT
Created attachment 379765 [details]
Patch

Patch for landing
Comment 5 Yusuke Suzuki 2019-09-27 14:15:05 PDT
(In reply to Mark Lam from comment #3)
> Comment on attachment 379763 [details]
> Patch
> 
> r=me too if jsc tests pass with a debug build.  The reason is because you
> added a new ThrowScope.  Need to make sure that there are no new exception
> check validation failures.

Thanks, I've just fixed and uploaded the patch for landing. I'll check EWS before landing it :)
Comment 6 Yusuke Suzuki 2019-09-27 14:15:36 PDT
<rdar://problem/55774964>
Comment 7 Yusuke Suzuki 2019-09-27 20:40:30 PDT
Committed r250479: <https://trac.webkit.org/changeset/250479>